Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to merge queries to share the same connection #29

Merged
merged 19 commits into from
Jul 30, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 16, 2023

Changelog

- description: |
    Refactoring to merge queries to share the same connection
  compatibility: no-api-changes
  type: feature

Context

Previously many of the commands were implemented in such a way as to open a new connection to the node for each query. These can cause multiple connections to opened and closed during the execution of a single command.

This change greatly reduces the number of connections used by having the queries share the same connection instead.

This PR is carefully split into may smaller commits that shows the refactoring changes incrementally. Each commit should compile on its own.

This draft PR confirms that integration tests still pass: IntersectMBO/cardano-node#5392

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/refactoring branch 3 times, most recently from 63d5f28 to e01f1a2 Compare June 22, 2023 03:16
@newhoggy newhoggy force-pushed the newhoggy/refactoring branch from e01f1a2 to b0ab115 Compare July 14, 2023 12:59
@newhoggy newhoggy changed the title Newhoggy/refactoring Refactoring to merge queries to share the same connection Jul 14, 2023
@newhoggy newhoggy requested review from carbolymer and Jimbo4350 July 14, 2023 14:32
@newhoggy newhoggy force-pushed the newhoggy/refactoring branch 2 times, most recently from de0ecb8 to cee1d8c Compare July 30, 2023 10:13
@newhoggy newhoggy force-pushed the newhoggy/refactoring branch from cee1d8c to e777849 Compare July 30, 2023 10:19
@newhoggy newhoggy added this pull request to the merge queue Jul 30, 2023
Merged via the queue into main with commit 6f10729 Jul 30, 2023
@newhoggy newhoggy deleted the newhoggy/refactoring branch July 30, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants