-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring to merge queries to share the same connection #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/refactoring
branch
3 times, most recently
from
June 22, 2023 03:16
63d5f28
to
e01f1a2
Compare
newhoggy
force-pushed
the
newhoggy/refactoring
branch
from
July 14, 2023 12:59
e01f1a2
to
b0ab115
Compare
newhoggy
changed the title
Newhoggy/refactoring
Refactoring to merge queries to share the same connection
Jul 14, 2023
carbolymer
approved these changes
Jul 17, 2023
newhoggy
force-pushed
the
newhoggy/refactoring
branch
2 times, most recently
from
July 30, 2023 10:13
de0ecb8
to
cee1d8c
Compare
newhoggy
force-pushed
the
newhoggy/refactoring
branch
from
July 30, 2023 10:19
cee1d8c
to
e777849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Previously many of the commands were implemented in such a way as to open a new connection to the node for each query. These can cause multiple connections to opened and closed during the execution of a single command.
This change greatly reduces the number of connections used by having the queries share the same connection instead.
This PR is carefully split into may smaller commits that shows the refactoring changes incrementally. Each commit should compile on its own.
This draft PR confirms that integration tests still pass: IntersectMBO/cardano-node#5392
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.