Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertFileOccurences doesn't check CBOR payload #415

Closed
smelc opened this issue Oct 31, 2023 · 0 comments · Fixed by #451
Closed

assertFileOccurences doesn't check CBOR payload #415

smelc opened this issue Oct 31, 2023 · 0 comments · Fixed by #451
Assignees
@smelc
Labels
test Modifies/extends the test suite

Comments

@smelc
Copy link
Contributor

smelc commented Oct 31, 2023

So we have a problem with our golden tests as they are. assertFileOccurences only checks the description of the text envelopes. It's not checking the CBOR payload.

https://github.com/input-output-hk/hedgehog-extras/blob/47df6f426d2b8fb01c66c279a818930eb8e5cd3f/src/Hedgehog/Extras/Test/File.hs#L302

I'll ask someone on the team to fix this.

Slack Message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smelc smelc

Labels
test Modifies/extends the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace usages of assertFileOccurences (6/6) IntersectMBO/cardano-cli
1 participant
@smelc