Apply suggestions from code review by @smelc

Co-authored-by: Clément Hurlin <[email protected]>
IntersectMBO · Oct 8, 2024 · 1265d19 · 1265d19
1 parent db10c8f
commit 1265d19
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/DRep.hs b/cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/DRep.hs
@@ -90,7 +90,7 @@ data GovernanceDRepMetadataHashCmdArgs era
 
 data DRepMetadataSource
   = DrepMetadataFileIn !(DRepMetadataFile In)
-  | DrepMetadataURL L.Url
+  | DrepMetadataURL !L.Url
   deriving Show
 
 data DRepHashGoal

diff --git a/cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/DRep.hs b/cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/DRep.hs
@@ -141,7 +141,7 @@ pExpectedDrepMetadataHash =
       , Opt.help $
           mconcat
             [ "Expected hash for the DRep metadata, for verification purposes. "
-            , "If provided, the hash of the DRep metadata will be compared to this value."
+            , "If provided, the hash of the DRep metadata is compared to this value."
             ]
       ]
 
@@ -221,7 +221,7 @@ pDRepMetadataSource :: Parser DRepMetadataSource
 pDRepMetadataSource =
   asum
     [ DrepMetadataFileIn <$> pFileInDirection "drep-metadata-file" "JSON Metadata file to hash."
-    , DrepMetadataURL <$> pUrl "drep-metadata-url" "URL to JSON Metadata file to hash."
+    , DrepMetadataURL <$> pUrl "drep-metadata-url" "URL pointing to the JSON Metadata file to hash."
     ]
 
 --------------------------------------------------------------------------------

diff --git a/cardano-cli/test/cardano-cli-golden/files/golden/help.cli b/cardano-cli/test/cardano-cli-golden/files/golden/help.cli
@@ -6808,7 +6808,7 @@ Usage: cardano-cli conway governance drep metadata-hash
                                                           | --out-file FILEPATH
                                                           ]
 
-  Calculate the hash of a metadata file.
+  Calculate the hash of a metadata file, optionally checking the obtained hash against an expected value.
 
 Usage: cardano-cli conway governance vote (create | view)