Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/Paste with passenger entities #2427

Open
2 tasks done
TerraMiner opened this issue Sep 17, 2023 · 12 comments · May be fixed by #2195
Open
2 tasks done

Copy/Paste with passenger entities #2427

TerraMiner opened this issue Sep 17, 2023 · 12 comments · May be fixed by #2195
Labels
Approved Added if an issue has been approved by a maintainer Bug Something isn't working Under investigation

Comments

@TerraMiner
Copy link

TerraMiner commented Sep 17, 2023

Server Implementation

Paper

Server Version

1.19.4

Describe the bug

When I copy 2 entities, one of which sits on the other, and try to paste it, the following error pops up, and the entity that sits is not pasted. It is also possible that this is due to the fact that entity 2 is ItemDisplay.

Error:
Unknown entity tag: BinaryTagType[CompoundBinaryTag 10]{tags={"UUIDMost"=BinaryTagType[LongBinaryTag 4 (numeric)]{value=7102332560571647860}, "Pos"=BinaryTagType[ListBinaryTag 9]{tags=[BinaryTagType[DoubleBinaryTag 6 (numeric)]{value=30.5d}, BinaryTagType[DoubleBinaryTag 6 (numeric)]{value=9.0d}, BinaryTagType[DoubleBinaryTag 6 (numeric)]{value=-3018.5d}], type=BinaryTagType[DoubleBinaryTag 6 (numeric)]}, "UUIDLeast"=BinaryTagType[LongBinaryTag 4 (numeric)]{value=-7375300107981949919}, "WorldUUIDMost"=BinaryTagType[LongBinaryTag 4 (numeric)]{value=7102332560571647860}, "PersistentIDLSB"=BinaryTagType[LongBinaryTag 4 (numeric)]{value=-7375300107981949919}, "PersistentIDMSB"=BinaryTagType[LongBinaryTag 4 (numeric)]{value=7102332560571647860}, "Id"=BinaryTagType[StringBinaryTag 8]{value="minecraft:item_display"}, "UUID"=BinaryTagType[IntArrayBinaryTag 11]{value=[1653640661, -2054142092, -1717195872, -1210715103]}, "WorldUUIDLeast"=BinaryTagType[LongBinaryTag 4 (numeric)]{value=-7375300107981949919}}}

To Reproduce

select any territory with 2 passengers entities
write //copy -e
paste this with //paste -e
and see this error and bug

Expected behaviour

Both entities with tags applied should be inserted.

Screenshots / Videos

https://youtu.be/Bw7aShMvKJ4

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/d843fd8b43e4439abef14aef78d64085

Fawe Version

FastAsyncWorldEdit-Bukkit-2.7.2-SNAPSHOT-557.jar

Checklist

Anything else?

No response

@TerraMiner TerraMiner added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Sep 17, 2023
@OneLiteFeather
Copy link
Member

Please use Paper

@TerraMiner
Copy link
Author

TerraMiner commented Sep 18, 2023

I installed the Paper core, nothing changed. Only the error color turned red)

I looked at 3 similar requests to this one, but in none of them did I see a solution or report that the bug was fixed/will be fixed

@OneLiteFeather
Copy link
Member

I'll look into reproducing it, also @TheMeinerLP (for your information, we talked about that)

@TerraMiner
Copy link
Author

I can record a video of the bug with the console in the background if needed.

@TerraMiner
Copy link
Author

I am not a regular user of this forum, but I would like to know how quickly this problem can be solved?

@OneLiteFeather
Copy link
Member

I can record a video of the bug with the console in the background if needed.

I looked into that error in your debugpaste and I think it would be good if you can make a video, so the developer know which case it is

@OneLiteFeather
Copy link
Member

I am not a regular user of this forum, but I would like to know how quickly this problem can be solved?

Depends on how complicate this turns out. We had a similar issue fixed but somehow it wasn't 100% fixed I guess.

@TerraMiner
Copy link
Author

TerraMiner commented Sep 21, 2023

https://youtu.be/Bw7aShMvKJ4

In the video you can see 2 entities, one of which is Interaction, the second Item Display. On the Interaction entity (Which you can see the hitbox), sits an entity of the Item Display type.

(Ignore the texture, the server is using a resource pack)

Edited:
I think that the error occurs in this place due to the absence of the Rotation tag.
image

@TheMeinerLP
Copy link
Member

https://youtu.be/Bw7aShMvKJ4

In the video you can see 2 entities, one of which is Interaction, the second Item Display. On the Interaction entity (Which you can see the hitbox), sits an entity of the Item Display type.

(Ignore the texture, the server is using a resource pack)

Edited: I think that the error occurs in this place due to the absence of the Rotation tag. image

Funny i don't see the original entities(makes very complicated) also the video is to short. The last 5~ frames shows the paste operation. But little bit to short to pause the video...

@TheMeinerLP TheMeinerLP linked a pull request Sep 21, 2023 that will close this issue
4 tasks
@TerraMiner
Copy link
Author

TerraMiner commented Sep 21, 2023

I made a quick but ugly code solution that will solve the problem only in a very narrow range of situations (will only fix ItemDisplay)
https://pastebin.com/5S1UfDkY

I hope this helps solve the problem as a whole.

@TheMeinerLP
Copy link
Member

Thats not the right solution. My PR for copy entites was not merged yet. Also there improvements missing for 5 Stacked Entity

@TerraMiner
Copy link
Author

Yes, I completely agree, but even this solution still satisfies the needs of builders who will work with a private plugin for fittings. Because they desperately needed a solution to this problem.

@OneLiteFeather OneLiteFeather added Bug Something isn't working Approved Added if an issue has been approved by a maintainer Under investigation and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Added if an issue has been approved by a maintainer Bug Something isn't working Under investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants