Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor README.md #2668

Merged
merged 9 commits into from
Apr 10, 2023
Merged

Conversation

SamerKhshiboun
Copy link
Collaborator

Tracked by [LRS-676]

@SamerKhshiboun SamerKhshiboun changed the title reorder README.md refactor README.md Mar 26, 2023
@SamerKhshiboun SamerKhshiboun force-pushed the readme_fix branch 8 times, most recently from 8eb7397 to ea1e4dd Compare April 6, 2023 00:19
README.md Outdated
[![humble][humble-badge]][humble]
[![foxy][foxy-badge]][foxy]
[![galactic][galactic-badge]][galactic]
[![eloquent][eloquent-badge]][eloquent]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove dashing and eloquent, also ubuntu 18

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* [Metadata Topic](#metadata)
* [Post-Processing Filters](#filters)
* [Available Services](#services)
* [Efficient intra-process communication](#intra-process)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can here add some coordination system section/point to doc.
Better to explain in the doc Vision sensors + IMU axis

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
- [ROS2 Foxy](https://docs.ros.org/en/foxy/Installation/Ubuntu-Install-Debians.html)
- [ROS2 Galactic](https://docs.ros.org/en/galactic/Installation/Ubuntu-Install-Debians.html)
- #### Ubuntu 18.04 :
- [ROS2 Dashing](https://docs.ros.org/en/dashing/Installation/Ubuntu-Install-Debians.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop this 2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@SamerKhshiboun SamerKhshiboun force-pushed the readme_fix branch 8 times, most recently from 9978f4e to 06270e9 Compare April 6, 2023 23:28
README.md Outdated
- [ROS2 Humble](https://docs.ros.org/en/humble/Installation/Ubuntu-Install-Debians.html)
- #### Ubuntu 20.04:
- [ROS2 Foxy](https://docs.ros.org/en/foxy/Installation/Ubuntu-Install-Debians.html)
- [ROS2 Galactic](https://docs.ros.org/en/galactic/Installation/Ubuntu-Install-Debians.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a deprecated notice on it (galactic)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


### Start the camera node
To start the camera node in ROS:
#### Parameters that can be modified during runtime:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use the "collapse" method more?
this section takes many lines and nor sure everyone needs it.
We can ether collapse or point to another doc if it's very big.

Same for the new CS chapter.
What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use the collapse as much as we want.
The main reason I don't want to split it to another docs, is the keep it simple for searching.
Most of users search with CTRL+F, so it is easier to keep everything in one document.
What do you think ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure NP.
Does CTRL + F works inside "details"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I tested it now, NO :)

@Nir-Az Nir-Az requested a review from remibettan April 9, 2023 12:39
README.md Outdated
[humble-badge]: https://img.shields.io/badge/-HUMBLE-orange?style=flat-square&logo=ros
[humble]: https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html
[foxy-badge]: https://img.shields.io/badge/-FOXY-orange?style=flat-square&logo=ros
[foxy]: https://docs.ros.org/en/rolling/Releases/Release-Foxy-Fitzroy.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify links

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review April 10, 2023 10:18
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Nir-Az Nir-Az merged commit 93af9cb into IntelRealSense:ros2-development Apr 10, 2023
@SamerKhshiboun SamerKhshiboun deleted the readme_fix branch May 9, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants