-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor README.md #2668
refactor README.md #2668
Conversation
8eb7397
to
ea1e4dd
Compare
… this to relative files
ea1e4dd
to
e130f9f
Compare
README.md
Outdated
[![humble][humble-badge]][humble] | ||
[![foxy][foxy-badge]][foxy] | ||
[![galactic][galactic-badge]][galactic] | ||
[![eloquent][eloquent-badge]][eloquent] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove dashing and eloquent, also ubuntu 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* [Metadata Topic](#metadata) | ||
* [Post-Processing Filters](#filters) | ||
* [Available Services](#services) | ||
* [Efficient intra-process communication](#intra-process) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can here add some coordination system section/point to doc.
Better to explain in the doc Vision sensors + IMU axis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
- [ROS2 Foxy](https://docs.ros.org/en/foxy/Installation/Ubuntu-Install-Debians.html) | ||
- [ROS2 Galactic](https://docs.ros.org/en/galactic/Installation/Ubuntu-Install-Debians.html) | ||
- #### Ubuntu 18.04 : | ||
- [ROS2 Dashing](https://docs.ros.org/en/dashing/Installation/Ubuntu-Install-Debians.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop this 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
01f23fb
to
f4dcecd
Compare
9978f4e
to
06270e9
Compare
06270e9
to
42fb45a
Compare
README.md
Outdated
- [ROS2 Humble](https://docs.ros.org/en/humble/Installation/Ubuntu-Install-Debians.html) | ||
- #### Ubuntu 20.04: | ||
- [ROS2 Foxy](https://docs.ros.org/en/foxy/Installation/Ubuntu-Install-Debians.html) | ||
- [ROS2 Galactic](https://docs.ros.org/en/galactic/Installation/Ubuntu-Install-Debians.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a deprecated
notice on it (galactic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
### Start the camera node | ||
To start the camera node in ROS: | ||
#### Parameters that can be modified during runtime: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use the "collapse" method more?
this section takes many lines and nor sure everyone needs it.
We can ether collapse or point to another doc if it's very big.
Same for the new CS chapter.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use the collapse as much as we want.
The main reason I don't want to split it to another docs, is the keep it simple for searching.
Most of users search with CTRL+F, so it is easier to keep everything in one document.
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure NP.
Does CTRL + F works inside "details"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I tested it now, NO :)
README.md
Outdated
[humble-badge]: https://img.shields.io/badge/-HUMBLE-orange?style=flat-square&logo=ros | ||
[humble]: https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html | ||
[foxy-badge]: https://img.shields.io/badge/-FOXY-orange?style=flat-square&logo=ros | ||
[foxy]: https://docs.ros.org/en/rolling/Releases/Release-Foxy-Fitzroy.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Tracked by [LRS-676]