Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latched QoS for Extrinsic topic when intra-process is used #2619

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Use latched QoS for Extrinsic topic when intra-process is used #2619

merged 2 commits into from
Feb 9, 2023

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Feb 9, 2023

Tracked on [DSO-18782]

SamerKhshiboun
SamerKhshiboun approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think we need to start documenting these things in some internal pages.
In general about RS ROS intra-process and specially for these issues.

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Feb 9, 2023

The comment inside the code should do it and the public documentations..
It's the best place to find answers regarding the code.
If you think something is missing let me know and I will add, I want it to be self explained or documented inside intra-process readme that we will have :)

@Nir-Az Nir-Az merged commit 4073f15 into IntelRealSense:ros2-development Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamerKhshiboun SamerKhshiboun SamerKhshiboun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nir-Az @SamerKhshiboun