fix rosbag device loading by preventing set_option to HDR/Gain/Exposure #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jul 13, 2022
| @@ -97,7 +97,8 @@ namespace realsense2_camera | |||
| BaseRealSenseNode(rclcpp::Node& node, | |||
| rs2::device dev, | |||
| std::shared_ptr<Parameters> parameters, | |||
| bool use_intra_process = false); | |||
| bool use_intra_process = false, | |||
| bool is_rosbag_file = false); | |||
There was a problem hiding this comment.
Since you are getting the rs2::device as well, try to drop the new parameter (all over the code) and use this API, see if it's possible:
if (dev.is<playback>())
There was a problem hiding this comment.
Thanks.
It make sense and make the code easier.
I saw the PR you talked about, but still I wanted to do this without asking the primary node about rosbag_filename parameter value, since I don't thinks this is the best way to do this.
There was a problem hiding this comment.
Great, Lets also check if this API works too:
sensor.is<playback_sensor>()
If this works we can drop more changes.
Worth checking
There was a problem hiding this comment.
Not sure it's possible, I don't see playback_sensor in the API
|
Have you seen this PR #2404 ? |
maloel
approved these changes
Jul 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by [LRS-445]
If rosbag file was loaded, a virtual device cannot set options of HDR/Exposure/Gain
Prevent that by asking if we are on a rosbag file