Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegal RosBag keys by replacing spaces with underscores #1161

Closed

Conversation

gravityrail
Copy link
Contributor

@gravityrail gravityrail commented Feb 9, 2018

Re-posting of #1129

This change also updates the format version from 3 to 4

====

When attempting to read the file with ROS Kinetic, I get the following error:

running rosbag...
[ INFO] [1517843870.611453253]: Opening /data/depthstream.bag

[FATAL] [1517843870.640881632]: Character [ ] at element [32] is not valid in Graph Resource Name [/device_0/sensor_0/option/Visual Preset/value].  Valid characters are a-z, A-Z, 0-9, / and _.

It appears that recent versions of ROS reject the option keys generated by librealsense.

This patch fixes this by replacing spaces with underscores late in the processing, so that Visual Preset becomes Visual_Preset.

@gravityrail
Copy link
Contributor Author

Re-reading the specs from this comment, I am not sure I've done this right. I am new to this code (and haven't written C++ for about 20 years) so it would be helpful if someone with more familiarity with both could have a shot at this.

@EverettBerry
Copy link

Would be great to see this merged. Just ran into it with a fresh ROS install.

@dorodnic dorodnic mentioned this pull request Oct 26, 2018
@radfordi
Copy link
Contributor

Fixed by #4537.

@dorodnic
Copy link
Contributor

Better late then never :) @gravityrail thank you for the original suggestion and the pull-request.

@dorodnic dorodnic closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants