Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing warning message in IntelInflater #176

Closed
lbergelson opened this issue Jan 3, 2023 · 1 comment · Fixed by #180
Closed

Confusing warning message in IntelInflater #176

lbergelson opened this issue Jan 3, 2023 · 1 comment · Fixed by #180
Assignees
@kdhanala

Comments

@lbergelson
Copy link
Contributor

I noticed that IntelInflator can issue a warning that says "Zero Bytes Written". This is confusing because it's happening during inflation when nothing is being written. I glanced at the class and it seems like there are a bunch of other probable copy/paste documentation errors where it looks like the deflator interface was copied and the text wasn't changed
@lbergelson lbergelson changed the title Confusing warning message in IntelInflator Confusing warning message in IntelInflater Jan 3, 2023
@lbergelson
Copy link
Contributor Author

lbergelson commented Jan 4, 2023 •
edited
Loading

As @jamesemery pointed out here: broadinstitute/gatk#8126 this warning gets emitted during normal operation because correctly written BGZF files have an empty terminator block to signal that they are finished. It should probably be removed entirely.

@kdhanala kdhanala self-assigned this Jan 24, 2023
kdhanala added a commit to kdhanala/GKL that referenced this issue May 8, 2023
@kdhanala
Removed warning message based on issue IntelLabs#176
3578135
@kdhanala kdhanala linked a pull request May 8, 2023 that will close this issue
Removed warning message based on issue #176 #180
Merged
mateuszsnowak pushed a commit that referenced this issue May 9, 2023
@kdhanala
Removed warning message based on issue #176 (#180)
58bedfe 
* Removed warning message based on issue #176

* Removing 'zero bytes written' warning message from IntelDeflater
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdhanala kdhanala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed warning message based on issue #176 kdhanala/GKL
2 participants
@lbergelson @kdhanala