Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Timing should be moved to the agent #26

Open
janxious opened this issue Aug 2, 2017 · 2 comments
Open

Method Timing should be moved to the agent #26

janxious opened this issue Aug 2, 2017 · 2 comments

Comments

@janxious
Copy link
Contributor

janxious commented Aug 2, 2017

We no longer rely on the functionality inside Metrician for any of our other instrumentation and it's very different from the rest of the pieces in terms of configuration, other than having an enable flag, so probably it should be in the piece of tech that is built around the idea of full customization instead of automatic make do right.

@janxious janxious changed the title Method Tracing should be moved to the agent Method Timing should be moved to the agent Sep 5, 2017
@jason-o-matic
Copy link
Member

We recently noticed that add_metrician_method_timer can have an issue if you use it on a class that gets loaded before metrician gets loaded, since it won't be defined yet. This could be another reason to move the method to the agent, though some care will still need to be taken with load order.

@jason-o-matic
Copy link
Member

Actually my previous comment is more related to your current working directory when running the ruby process. https://github.com/Instrumental/metrician-ruby/blob/master/lib/metrician/configuration.rb#L32-L33 uses Dir.pwd to detect your app location, but if you run ruby from a different directory it won't current find your application metrician config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants