Media wiki migration second set #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SphinxExamples requires VTK with compatible python bindings for python 3.6 or greater.
When building ITKEx, ensure that the appropriate level of compiler standard is used.
hjmjohnson
added
the
type:Enhancement
hjmjohnson
commented
Jun 10, 2019
There was a problem hiding this comment.
@thewtex @dzenanz This was a huge amount of work. We know it has more work to do but would like to get this integrated as a starting point for the next phase of updates.
Many of the new examples have tests that are failing. We are trying to figure out how to efficiently create these into passing tests.
This was referenced Jun 10, 2019
dzenanz
reviewed
Jun 10, 2019
src/Compatibility/Deprecated/ResampleITK::VectorImage/CMakeLists.txt
Outdated
Show resolved
Hide resolved
|
Does this close #15? |
dzenanz
reviewed
Jun 10, 2019
hjmjohnson
force-pushed
the
media-wiki-migration-second-set
branch
2 times, most recently
from
fe569df
to
347d91e
Compare
Moved several hundered wiki-examples from the media wiki site to the sphinx examples site.
The Media Wiki examples had several support files used in the examples.
|
@dzenanz I hit your quick review comments. I'm sure that there are many other items like those you identified, but as you said, this is a HUGE undertaking. I believe that the current code with problems is worth merging so that we can work on the refinements as the next steps. The integration with ITK proper is MUCH easier with some iterative markers in these examples. Additionally, it is sometimes easier to identify problems from the generated sphinx example pages than it is from the main codebase. Hans Please rebase and merge if you are content with my argument. The student "mseng10" is in a holding pattern this week until we identify a new stable working point. |
|
@dzenanz Awesome! Thank you. |
|
As this is a huge effort, I want to make it easier to you and @mseng10. Hoping everything will end up tidy, not too far into the future 😄 |
|
@mseng10 is working on adding reference images this week. |
|
@hjmjohnson @mseng10 amazing work!!! 🥇 🌮 🔢 |
jhlegarreta
added a commit
to jhlegarreta/ITKSoftwareGuide
that referenced
this pull request
May 12, 2020
Miscellaneus fixes in the `Introduction` and `Installation` chapters: - Fix the development environment names. - Remove compiler support dates prior to 2016 from the compiler support table. - Remove the deprecated reference to the Wiki Examples: examples are entirely hosted in https://itk.org/ITKExamples/ since a series of PRs including InsightSoftwareConsortium/ITKSphinxExamples#108 and InsightSoftwareConsortium/ITKSphinxExamples#109. - Fix the `Utilities` and `Wrapping` parent folders. - Tke advantage of the commit to order alphabetically the ITK's main folders. Take advantage of the commit for other minor style changes (e.g. period at the end of sentences, proper LaTex quote syntax, etc.). Take advantage of the commit to limit the line length to 79 characters in the ITK's folder structure bullet points.
jhlegarreta
added a commit
to jhlegarreta/ITKSoftwareGuide
that referenced
this pull request
May 12, 2020
Miscellaneus fixes in the `Introduction` and `Installation` chapters: - Fix the development environment names. - Remove compiler support dates prior to 2016 from the compiler support table. - Remove the deprecated reference to the Wiki Examples: examples are entirely hosted in https://itk.org/ITKExamples/ since a series of PRs including InsightSoftwareConsortium/ITKSphinxExamples#108 and InsightSoftwareConsortium/ITKSphinxExamples#109. - Fix the `Utilities` and `Wrapping` parent folders. - Tke advantage of the commit to order alphabetically the ITK's main folders. Take advantage of the commit for other minor style changes (e.g. period at the end of sentences, proper LaTex quote syntax, etc.). Take advantage of the commit to limit the line length to 79 characters in the ITK's folder structure bullet points.
jhlegarreta
added a commit
to jhlegarreta/ITKSoftwareGuide
that referenced
this pull request
May 12, 2020
Miscellaneus fixes in the `Introduction` and `Installation` chapters: - Fix the development environment names. - Remove compiler support dates prior to 2016 from the compiler support table. - Remove the deprecated reference to the Wiki Examples: examples are entirely hosted in https://itk.org/ITKExamples/ since a series of PRs including InsightSoftwareConsortium/ITKSphinxExamples#108 and InsightSoftwareConsortium/ITKSphinxExamples#109. - Fix the `Utilities` and `Wrapping` parent folders. - Mention the raw binary files and the SHA512 hash files in the `Testing` folder paragraph. - Tke advantage of the commit to order alphabetically the ITK's main folders. Take advantage of the commit for other minor style changes (e.g. period at the end of sentences, proper LaTex quote syntax, etc.). Take advantage of the commit to limit the line length to 79 characters in the ITK's folder structure bullet points.
jhlegarreta
added a commit
to jhlegarreta/ITKSoftwareGuide
that referenced
this pull request
May 13, 2020
Miscellaneus fixes in the `Introduction` and `Installation` chapters: - Fix the development environment names. - Remove compiler support dates prior to 2016 from the compiler support table. - Remove the deprecated reference to the Wiki Examples: examples are entirely hosted in https://itk.org/ITKExamples/ since a series of PRs including InsightSoftwareConsortium/ITKSphinxExamples#108 and InsightSoftwareConsortium/ITKSphinxExamples#109. - Fix the `Utilities` and `Wrapping` parent folders. - Mention the raw binary files and the SHA512 hash files in the `Testing` folder paragraph. - Take advantage of the commit to order alphabetically the ITK's main folders. Take advantage of the commit for other minor style changes (e.g. period at the end of sentences, proper LaTex quote syntax, etc.). Take advantage of the commit to limit the line length to 79 characters in the ITK's folder structure bullet points.
thewtex
pushed a commit
to jhlegarreta/ITKSoftwareGuide
that referenced
this pull request
May 14, 2020
Miscellaneus fixes in the `Introduction` and `Installation` chapters: - Fix the development environment names. - Remove compiler support dates prior to 2016 from the compiler support table. - Remove the deprecated reference to the Wiki Examples: examples are entirely hosted in https://itk.org/ITKExamples/ since a series of PRs including InsightSoftwareConsortium/ITKSphinxExamples#108 and InsightSoftwareConsortium/ITKSphinxExamples#109. - Fix the `Utilities` and `Wrapping` parent folders. - Mention the raw binary files and the SHA512 hash files in the `Testing` folder paragraph. - Take advantage of the commit to order alphabetically the ITK's main folders. Take advantage of the commit for other minor style changes (e.g. period at the end of sentences, proper LaTex quote syntax, etc.). Take advantage of the commit to limit the line length to 79 characters in the ITK's folder structure bullet points.
jhlegarreta
added a commit
to jhlegarreta/ITKSoftwareGuide
that referenced
this pull request
May 14, 2020
Miscellaneus fixes in the `Introduction` and `Installation` chapters: - Fix the development environment names. - Rework the compiler list: update to currently supported versions. - Remove the compiler support/deprecation cycle table due to difficulties in keeping it up to date. - Remove the deprecated reference to the Wiki Examples: examples are entirely hosted in https://itk.org/ITKExamples/ since a series of PRs including InsightSoftwareConsortium/ITKSphinxExamples#108 and InsightSoftwareConsortium/ITKSphinxExamples#109. - Update the `vxl` link. - Fix the `Utilities` and `Wrapping` parent folders. - Mention the raw binary files and the SHA512 hash files in the `Testing` folder paragraph. - Take advantage of the commit to order alphabetically the ITK's main folders. Take advantage of the commit for other minor style changes (e.g. period at the end of sentences, proper LaTex quote syntax, etc.). Take advantage of the commit to limit the line length to 79 characters in the ITK's folder structure bullet points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the media wiki examples are migrated and building with the sphinx examples hierarchy now.