Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itk-elastix 0.15.0 release has no installation for python 3.8 and python 3.9 #181

Closed
Svdvoort opened this issue Nov 30, 2022 · 11 comments
Closed

Comments

@Svdvoort
Copy link

The 0.15.0 release of itk-elastix has no install candidates for python 3.8 and python 3.9.
Looking at the pypi files there are install candidates for python 3.7, 3.10 and 3.11 but only 3.8 and 3.9 are missing.

@dzenanz
Copy link
Member

dzenanz commented Nov 30, 2022

It could be another manifestation of InsightSoftwareConsortium/ITKPythonPackage#235?

@tbirdso
Copy link
Collaborator

tbirdso commented Nov 30, 2022

The CI PyPI upload workflow failed due to exceeded file size limits:

https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/3577645998/jobs/6022259374

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Project size too large. Limit for project 'itk-elastix' total size is  
         10 GB. See https://pypi.org/help/#project-size-limit       

It looks like 3.10, 3.11, and then 3.7 were uploaded successfully and the size limit was hit at 3.8, thus 3.9 was not attempted.

I am uncertain whether these particular packages are larger for some reason or if the 5.3 update somehow narrowly put itk-elastix over the 10GB limit. Perhaps @thewtex could weigh in on managing PyPI package sizes?

@dzenanz
Copy link
Member

dzenanz commented Nov 30, 2022

If we remove some older versions from PyPI, that would create space for the latest version. Or maybe remove some beta/RC versions? Or some minor versions? Or ask PyPI maintainers to increase the limit for the project?

@tbirdso
Copy link
Collaborator

tbirdso commented Nov 30, 2022

@dzenanz I'm good with any of the solutions you've proposed. It looks like @thewtex removed several ITK module release candidates on PyPI recently, probably to make room for the v5.3.0 release? https://pypi.org/project/itk-numerics/#history

It will fall to one of the itk-elastix PyPI maintainers (@dzenanz @hjmjohnson @thewtex ) to decide what packages should be dropped from PyPI.

@dzenanz
Copy link
Member

dzenanz commented Nov 30, 2022

I prefer Matt to chime in or decide what to sack.

@thewtex
Copy link
Member

thewtex commented Nov 30, 2022

Yes, we just hit the default 10 GB limit, stopping the uploads.

Yes, I had to delete a few old itk- release candidate packages to keep under the size limit.

I created a request to increase the itk-elastix size limit here: pypi/support#2449

In the meantime, I also deleted the oldest releases, and I will restart the CI build. Hopefully they will upload.

@tbirdso
Copy link
Collaborator

tbirdso commented Nov 30, 2022

@thewtex It looks like Linux and MacOS Python 3.8 packages were uploaded, but the size limit was exceeded before Windows 3.8 or any 3.9 packages were uploaded: https://pypi.org/project/itk-elastix/#files

@thewtex
Copy link
Member

thewtex commented Nov 30, 2022

I deleted a few more releases and restarted the Action.

@thewtex
Copy link
Member

thewtex commented Nov 30, 2022

Related, we should also address #182 #183

@tbirdso
Copy link
Collaborator

tbirdso commented Nov 30, 2022

Looks like we are just missing Windows 3.9 packages now.

@thewtex
Copy link
Member

thewtex commented Nov 30, 2022

Third time's the charm 💎

@thewtex thewtex closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants