ENH: Add macOS ARM GitHub Actions configuration #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:Infrastructure
thewtex
force-pushed
the
macos-arm-ci
branch
2 times, most recently
from
71636be
to
d2548db
Compare
blowekamp
reviewed
Mar 15, 2024
thewtex
force-pushed
the
macos-arm-ci
branch
7 times, most recently
from
9e9a4e0
to
10ed6f0
Compare
|
FYI: I have not been able to build simpleITK on this GH hosted runner as it has 3 cores and only 7GB of memory: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners |
|
@blowekamp the SimpleITK build runs out of memory when linking? |
Fix CLANG_FORMAT_EXECUTABLE location with find_program to address: CMake Error at CMake/ITKClangFormatSetup.cmake:62 (message): Missing suitable clang-format executable, set CLANG_FORMAT_EXECUTABLE variable to version 8.0 Call Stack (most recent call first): CMakeLists.txt:586 (include) Improve host system detection for the clang-format binary download.
Addresses:
3.29.0/share/cmake/Modules/CMakeDependentOption.cmake:89 (message):
Policy CMP0127 is not set: cmake_dependent_option() supports full Condition
Syntax. Run "cmake --help-policy CMP0127" for policy details. Use the
cmake_policy command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:107 (cmake_dependent_option)
This warning is for project developers. Use -Wno-dev to suppress it.
Submitted upstream:
zlib-ng/zlib-ng#1709
github-actions
bot
added
area:Core
thewtex
force-pushed
the
macos-arm-ci
branch
2 times, most recently
from
4025693
to
d12f341
Compare
Addresses: ld: warning: ignoring duplicate libraries: '-lm' With Apple Clang 15. This approach works with older CMake but based on: https://gitlab.kitware.com/cmake/cmake/-/commit/7b99c42e57b11afe818827ac537ca020c020addd
Slight differences on this platform.
github-actions
bot
added
type:Testing
thewtex
changed the title
Uses new GitHub Actions dashboard script
github-actions
bot
added
the
type:Enhancement
hjmjohnson
approved these changes
Apr 10, 2024
| @@ -209,6 +209,7 @@ set(BASELINE "${ITK_DATA_ROOT}/Baseline/Common") | |||
| set(TEMP ${ITK_TEST_OUTPUT_DIR}) | |||
|
|
|||
| add_executable(itkMathTest itkMathTest.cxx) | |||
| target_link_options(itkMathTest PRIVATE "$<$<AND:$<C_COMPILER_ID:AppleClang>,$<VERSION_GREATER_EQUAL:$<C_COMPILER_VERSION>,15.0>>:LINKER:-no_warn_duplicate_libraries>") | |||
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 7, 2024
Upgraded ITK on the CI to version 5.4rc04: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.4rc04 (commits from 2024-04-06 to 2024-04-16: InsightSoftwareConsortium/ITK@v5.4rc03...v5.4rc04) Including pull request InsightSoftwareConsortium/ITK#4519 commit InsightSoftwareConsortium/ITK@7231bf7 which suppresses clang "ld: warning: ignoring duplicate libraries: '-lm'". Follow-up to pull request #1089 commit 095ebcc
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 7, 2024
Upgraded ITK on the CI to version 5.4rc04: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.4rc04 (commits from 2024-04-06 to 2024-04-16: InsightSoftwareConsortium/ITK@v5.4rc03...v5.4rc04) Including pull request InsightSoftwareConsortium/ITK#4519 commit InsightSoftwareConsortium/ITK@7231bf7 which suppresses clang "ld: warning: ignoring duplicate libraries: '-lm'". Follow-up to pull request #1089 commit 095ebcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.