BUG: Use GDCM as private dependency in ITKIOGDCM #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
approved these changes
Apr 14, 2020
Make the third partly library a private dependency, for the ITK GDCM ImageIO modules. This follows best practices of data encapsulation. Move the implementation of the destructor to the cxx file as a best practice as it ensure intonation of the vtable in the library.
blowekamp
force-pushed
the
GDCMImageIORemoveUsePrivateGDCM
branch
from
1759484
to
ca1913c
Compare
hjmjohnson
approved these changes
Apr 14, 2020
SimonRit
pushed a commit
to RTKConsortium/RTK
that referenced
this pull request
Apr 15, 2020
This dependency is missing since InsightSoftwareConsortium/ITK#1768.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the third partly library a private dependency, for the ITK GDCM
ImageIO modules. This follows best practices of data encapsulation.
Move the implementation of the destructor to the cxx file as a best
practice as it ensure intonation of the vtable in the library.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.