Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added HoughTransform2DCirclesImageFilter::UseImageSpacing #153

Merged
merged 1 commit into from
Nov 10, 2018
Merged

ENH: Added HoughTransform2DCirclesImageFilter::UseImageSpacing #153

merged 1 commit into from
Nov 10, 2018

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Nov 8, 2018

Added UseImageSpacing property to allow switching off the
corresponding property from both the image function
(GaussianDerivativeImageFunction) and the smoothing filter
(DiscreteGaussianImageFilter) that are internally used by
HoughTransform2DCirclesImageFilter.

HoughTransform2DCirclesImageFilter::UseImageSpacing is initialized by
'true', in order to preserve the original behavior, by default.

@thewtex
Copy link
Member

thewtex commented Nov 8, 2018

ITK.macOS time probe test failure is a false positive.

@N-Dekker
Copy link
Contributor Author

N-Dekker commented Nov 8, 2018

ITK.macOS time probe test failure is a false positive.

Thanks @thewtex! So what about request build: osx? 😉

@thewtex
Copy link
Member

thewtex commented Nov 8, 2018

Thanks @thewtex! So what about request build: osx? wink

@N-Dekker please try this:

git commit --amend
git review-push --force

If it works for you 🎰 , then we will document it 📚.

Added UseImageSpacing property to allow switching off the
corresponding property from both the image function
(GaussianDerivativeImageFunction) and the smoothing filter
(DiscreteGaussianImageFilter) that are internally used by
HoughTransform2DCirclesImageFilter.

HoughTransform2DCirclesImageFilter::UseImageSpacing is initialized by
'true', in order to preserve the original behavior, by default.
@N-Dekker
Copy link
Contributor Author

N-Dekker commented Nov 9, 2018

@thewtex wrote:

please try this:

git commit --amend
git review-push --force

Thanks Matt! Indeed, these two lines appear to trigger a rebuild :-) Still it would be easier for me if I could just trigger a rebuild via some web interface. (By pressing a rebuild button, or typing something like request build: all.) Because I don't always have access to the computer that has my ITK fork clone.

@thewtex
Copy link
Member

thewtex commented Nov 10, 2018

@N-Dekker I added #166 to track implementation of the comment build commands :-).

@thewtex thewtex merged commit 96bb3f2 into InsightSoftwareConsortium:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants