STYLE: Replace Unused calls with C++17 [[maybe_unused]] attribute

Removed `Unused(singletonIndex)` calls. Instead, added `[[maybe_unused]]` to `singletonIndex` variable declarations.
InsightSoftwareConsortium · Nov 8, 2023 · a28242a · a28242a
1 parent fed6ed0
commit a28242a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Modules/Core/Common/include/itkSingleton.h b/Modules/Core/Common/include/itkSingleton.h
@@ -124,9 +124,8 @@ template <typename T>
 T *
 Singleton(const char * globalName, std::function<void()> deleteFunc)
 {
-  static SingletonIndex * singletonIndex = SingletonIndex::GetInstance();
-  Unused(singletonIndex);
-  T * instance = SingletonIndex::GetInstance()->GetGlobalInstance<T>(globalName);
+  [[maybe_unused]] static SingletonIndex * singletonIndex = SingletonIndex::GetInstance();
+  T *                                      instance = SingletonIndex::GetInstance()->GetGlobalInstance<T>(globalName);
   if (instance == nullptr)
   {
     instance = new T;

diff --git a/Modules/Core/Common/src/itkObjectFactoryBase.cxx b/Modules/Core/Common/src/itkObjectFactoryBase.cxx
@@ -832,8 +832,7 @@ ObjectFactoryBase::SynchronizeObjectFactoryBase(void * objectFactoryBasePrivate)
 std::list<ObjectFactoryBase *>
 ObjectFactoryBase::GetRegisteredFactories()
 {
-  //  static SingletonIndex * singletonIndex = SingletonIndex::GetInstance();
-  //  Unused(singletonIndex);
+  //  [[maybe_unused]] static SingletonIndex * singletonIndex = SingletonIndex::GetInstance();
   ObjectFactoryBase::Initialize();
   return m_PimplGlobals->m_RegisteredFactories;
 }