STYLE: Replace BoundaryConditionPointerType w/ BoundaryConditionType *

Made it clearer that ConvolutionImageFilterBase and PadImageFilterBase use a _raw_ pointer to the `BoundaryCondition`.
InsightSoftwareConsortium · Mar 27, 2024 · 839955e · 839955e
1 parent 5f3adbd
commit 839955e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/Modules/Filtering/Convolution/include/itkConvolutionImageFilterBase.h b/Modules/Filtering/Convolution/include/itkConvolutionImageFilterBase.h
@@ -93,8 +93,8 @@ class ITK_TEMPLATE_EXPORT ConvolutionImageFilterBase : public ImageToImageFilter
   using DefaultBoundaryConditionType = ZeroFluxNeumannBoundaryCondition<TInputImage>;
 
   /** Set/get the boundary condition. */
-  itkSetMacro(BoundaryCondition, BoundaryConditionPointerType);
-  itkGetConstMacro(BoundaryCondition, BoundaryConditionPointerType);
+  itkSetMacro(BoundaryCondition, BoundaryConditionType *);
+  itkGetConstMacro(BoundaryCondition, BoundaryConditionType *);
 
   /** Set/get the image kernel. */
   itkSetInputMacro(KernelImage, KernelImageType);
@@ -157,7 +157,7 @@ class ITK_TEMPLATE_EXPORT ConvolutionImageFilterBase : public ImageToImageFilter
   bool m_Normalize{ false };
 
   DefaultBoundaryConditionType m_DefaultBoundaryCondition{};
-  BoundaryConditionPointerType m_BoundaryCondition{};
+  BoundaryConditionType *      m_BoundaryCondition{};
 
   OutputRegionModeEnum m_OutputRegionMode{ ConvolutionImageFilterBaseEnums::ConvolutionImageFilterOutputRegion::SAME };
 };

diff --git a/Modules/Filtering/ImageGrid/include/itkPadImageFilterBase.h b/Modules/Filtering/ImageGrid/include/itkPadImageFilterBase.h
@@ -86,8 +86,8 @@ class ITK_TEMPLATE_EXPORT PadImageFilterBase : public ImageToImageFilter<TInputI
   static constexpr unsigned int ImageDimension = TInputImage::ImageDimension;
 
   /** Set/get the boundary condition. */
-  itkSetMacro(BoundaryCondition, BoundaryConditionPointerType);
-  itkGetConstMacro(BoundaryCondition, BoundaryConditionPointerType);
+  itkSetMacro(BoundaryCondition, BoundaryConditionType *);
+  itkGetConstMacro(BoundaryCondition, BoundaryConditionType *);
 
 protected:
   PadImageFilterBase();
@@ -110,10 +110,10 @@ class ITK_TEMPLATE_EXPORT PadImageFilterBase : public ImageToImageFilter<TInputI
 
   /** Method for subclasses to set the boundary condition. */
   void
-  InternalSetBoundaryCondition(const BoundaryConditionPointerType boundaryCondition);
+  InternalSetBoundaryCondition(BoundaryConditionType * const boundaryCondition);
 
 private:
-  BoundaryConditionPointerType m_BoundaryCondition{};
+  BoundaryConditionType * m_BoundaryCondition{};
 };
 
 } // end namespace itk

diff --git a/Modules/Filtering/ImageGrid/include/itkPadImageFilterBase.hxx b/Modules/Filtering/ImageGrid/include/itkPadImageFilterBase.hxx
@@ -128,7 +128,7 @@ PadImageFilterBase<TInputImage, TOutputImage>::DynamicThreadedGenerateData(
 template <typename TInputImage, typename TOutputImage>
 void
 PadImageFilterBase<TInputImage, TOutputImage>::InternalSetBoundaryCondition(
-  const BoundaryConditionPointerType boundaryCondition)
+  BoundaryConditionType * const boundaryCondition)
 {
   m_BoundaryCondition = boundaryCondition;
 }