STYLE: Use true as default member initializer for m_UseImageDirection

Removed `m_UseImageDirection = true` assignment from the function body of the corresponding constructors. Following C++ Core Guidelines, February 15, 2024 "Prefer initialization to assignment in constructors", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c49-prefer-initialization-to-assignment-in-constructors
InsightSoftwareConsortium · Mar 12, 2024 · 16456e1 · 16456e1
1 parent ddea89f
commit 16456e1
Show file tree

Hide file tree

Showing 10 changed files with 6 additions and 13 deletions.
diff --git a/Modules/Compatibility/Deprecated/include/itkVectorCentralDifferenceImageFunction.h b/Modules/Compatibility/Deprecated/include/itkVectorCentralDifferenceImageFunction.h
@@ -147,7 +147,7 @@ class ITK_TEMPLATE_EXPORT VectorCentralDifferenceImageFunction
 private:
   // flag to take or not the image direction into account
   // when computing the derivatives.
-  bool m_UseImageDirection{};
+  bool m_UseImageDirection{ true };
 };
 } // end namespace itk
 

diff --git a/Modules/Compatibility/Deprecated/include/itkVectorCentralDifferenceImageFunction.hxx b/Modules/Compatibility/Deprecated/include/itkVectorCentralDifferenceImageFunction.hxx
@@ -24,9 +24,7 @@ namespace itk
 
 template <typename TInputImage, typename TCoordRep>
 VectorCentralDifferenceImageFunction<TInputImage, TCoordRep>::VectorCentralDifferenceImageFunction()
-{
-  this->m_UseImageDirection = true;
-}
+{}
 
 template <typename TInputImage, typename TCoordRep>
 void

diff --git a/Modules/Core/ImageFunction/include/itkBSplineInterpolateImageFunction.h b/Modules/Core/ImageFunction/include/itkBSplineInterpolateImageFunction.h
@@ -411,7 +411,7 @@ class ITK_TEMPLATE_EXPORT BSplineInterpolateImageFunction : public InterpolateIm
 
   // flag to take or not the image direction into account when computing the
   // derivatives.
-  bool m_UseImageDirection{};
+  bool m_UseImageDirection{ true };
 
   ThreadIdType                          m_NumberOfWorkUnits{};
   std::unique_ptr<vnl_matrix<long>[]>   m_ThreadedEvaluateIndex;

diff --git a/Modules/Core/ImageFunction/include/itkBSplineInterpolateImageFunction.hxx b/Modules/Core/ImageFunction/include/itkBSplineInterpolateImageFunction.hxx
@@ -51,7 +51,6 @@ BSplineInterpolateImageFunction<TImageType, TCoordRep, TCoefficientType>::BSplin
   m_SplineOrder = 0;
   unsigned int SplineOrder = 3;
   this->SetSplineOrder(SplineOrder);
-  this->m_UseImageDirection = true;
 }
 
 template <typename TImageType, typename TCoordRep, typename TCoefficientType>

diff --git a/Modules/Core/ImageFunction/include/itkCentralDifferenceImageFunction.h b/Modules/Core/ImageFunction/include/itkCentralDifferenceImageFunction.h
@@ -260,7 +260,7 @@ class ITK_TEMPLATE_EXPORT CentralDifferenceImageFunction : public ImageFunction<
 
   // flag to take or not the image direction into account
   // when computing the derivatives.
-  bool m_UseImageDirection{};
+  bool m_UseImageDirection{ true };
 
   // interpolator
   InterpolatorPointer m_Interpolator{};

diff --git a/Modules/Core/ImageFunction/include/itkCentralDifferenceImageFunction.hxx b/Modules/Core/ImageFunction/include/itkCentralDifferenceImageFunction.hxx
@@ -26,8 +26,6 @@ namespace itk
 template <typename TInputImage, typename TCoordRep, typename TOutputType>
 CentralDifferenceImageFunction<TInputImage, TCoordRep, TOutputType>::CentralDifferenceImageFunction()
 {
-  this->m_UseImageDirection = true;
-
   using LinearInterpolatorType = LinearInterpolateImageFunction<TInputImage, TCoordRep>;
   this->m_Interpolator = LinearInterpolatorType::New();
 }

diff --git a/Modules/Filtering/ImageGradient/include/itkGradientImageFilter.h b/Modules/Filtering/ImageGradient/include/itkGradientImageFilter.h
@@ -223,7 +223,7 @@ class ITK_TEMPLATE_EXPORT GradientImageFilter : public ImageToImageFilter<TInput
 
   // flag to take or not the image direction into account
   // when computing the derivatives.
-  bool m_UseImageDirection{};
+  bool m_UseImageDirection{ true };
 
   // allow setting the the m_BoundaryCondition
   ImageBoundaryCondition<TInputImage, TInputImage> * m_BoundaryCondition{};

diff --git a/Modules/Filtering/ImageGradient/include/itkGradientImageFilter.hxx b/Modules/Filtering/ImageGradient/include/itkGradientImageFilter.hxx
@@ -34,7 +34,6 @@ GradientImageFilter<TInputImage, TOperatorValueType, TOutputValueType, TOutputIm
 {
   // default boundary condition
   m_BoundaryCondition = new ZeroFluxNeumannBoundaryCondition<TInputImage>();
-  this->m_UseImageDirection = true;
   this->DynamicMultiThreadingOn();
   this->ThreaderUpdateProgressOff();
 }

diff --git a/Modules/Filtering/ImageGradient/include/itkGradientRecursiveGaussianImageFilter.h b/Modules/Filtering/ImageGradient/include/itkGradientRecursiveGaussianImageFilter.h
@@ -255,7 +255,7 @@ class ITK_TEMPLATE_EXPORT GradientRecursiveGaussianImageFilter : public ImageToI
   bool m_NormalizeAcrossScale{};
 
   /** Take into account image orientation when computing the Gradient */
-  bool m_UseImageDirection{};
+  bool m_UseImageDirection{ true };
 
   /** Standard deviation of the gaussian */
   SigmaArrayType m_Sigma{};

diff --git a/Modules/Filtering/ImageGradient/include/itkGradientRecursiveGaussianImageFilter.hxx b/Modules/Filtering/ImageGradient/include/itkGradientRecursiveGaussianImageFilter.hxx
@@ -30,7 +30,6 @@ template <typename TInputImage, typename TOutputImage>
 GradientRecursiveGaussianImageFilter<TInputImage, TOutputImage>::GradientRecursiveGaussianImageFilter()
 {
   m_NormalizeAcrossScale = false;
-  this->m_UseImageDirection = true;
 
   static_assert(ImageDimension > 0, "Images shall have one dimension at least");
   const unsigned int imageDimensionMinus1 = ImageDimension - 1;