Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesan parameter listing #82

Closed
docNord opened this issue Apr 1, 2023 · 2 comments · Fixed by #103
Closed

Mesan parameter listing #82

docNord opened this issue Apr 1, 2023 · 2 comments · Fixed by #103
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@docNord
Copy link
Collaborator

docNord commented Apr 1, 2023

Currently, the output from calling Mesan parameters is appalingly difficult to read (a json dictionary style list which does not read well). There should be a function which writes the names of the parameters similar to the Metobs parameters function.

from smhi.mesan import Mesan
client =Mesan()
client.parameters

#Reads better, example:
import pandas as pd
df = pd.DataFrame(client.parameters)
df["name"]
@docNord docNord added the enhancement New feature or request label Apr 1, 2023
@mgcth mgcth added this to the 0.1.1 milestone Apr 3, 2023
@mgcth mgcth modified the milestones: 0.1.1, 0.1.2 Apr 14, 2023
@docNord
Copy link
Collaborator Author

docNord commented Mar 1, 2024

Changing the output format to a dataframe, I take the addition to milestones as an approval for introducing this change?

@mgcth
Copy link
Collaborator

mgcth commented Mar 2, 2024

I'm not sure a data frame is the correct format here. How about a dataclass, in that way we can keep the schema fixed?

@mgcth mgcth mentioned this issue Mar 24, 2024
11 tasks
@mgcth mgcth self-assigned this Mar 29, 2024
@mgcth mgcth modified the milestones: 0.1.3, 0.2.0 Mar 29, 2024
@mgcth mgcth closed this as completed in #103 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants