-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce method side effects #66
Comments
How do you think the structure should be in order to avoid such side effects, and what side effects are you thinking of? |
We could probably delete this class altogether Line 12 in 6be598b
For example, Lines 74 to 93 in 6be598b
There are probably more examples. I think it makes the code harder to test and reason about, and as a user, I would expect I'd go for pure functions as much as possible, as long as we don't copy data unecessairly but that shouldn't be a big problem as the data here is relatively small for each request. It should simplify any future multithreading/async additions we'd want to add. |
So... Should we pencil out a plan for how we want to structure things before we start remodeling? Or do you already have a blueprint like this in mind? |
Maybe we should try to release version 0.1.0 first :) |
Good point :) |
Description
Reduce or eliminate (as much as possible) side effects from our methods. Along these lines, remove the Metobs class altogether and just use the individual components.
The text was updated successfully, but these errors were encountered: