Private Tab may break in Firefox 28 (or later?)

[Yoric]

Hi,

We are working on a number of optimizations to Session Restore for Firefox 25 (or 26). To perform one major optimization, we will need to get rid of the state string attached to "sessionstore-state-write" that you are currently using.

We need to find a way to ensure that this will not break Private Tab.

I have the feeling that if:

• we keep sending "sessionstore-state-write" but without a nsISupportsString;
• we don't save tabs that have attribute usePrivateBrowsing.

This will be sufficient to ensure that your add-on does not break and does not lose features. Could you confirm?

[Infocatcher]

Yes, I use "sessionstore-state-write" notification only to remove tabs with "privateTab-isPrivate" attribute from session data (because I don't have real tabs here). And only tabs with nsILoadContext.usePrivateBrowsing flag have that DOM attribute.

So, if you filter out all private tabs for me, I don't need "sessionstore-state-write" notification at all.

[Yoric]

Let's do that.

[Infocatcher]

I updated the title to not confuse users:

-Private Tab may break in Firefox 25
+Private Tab may break in Firefox 28 (or later?)