Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs lost starting with Firefox nightly April 21 build, if e10s disabled, due to bug 1345090 #262

Open
C4rb0n opened this issue Apr 27, 2017 · 6 comments

Comments

@C4rb0n
Copy link

C4rb0n commented Apr 27, 2017

If Private Tab extension is enabled on a Firefox nightly build that contains bug 1345090 (landed on April 21), and e10s is also disabled on the browser, sessionrestore loses tabs. The only remedy is to either disable Private Tab or enable e10s.

A fix would be appreciated. Thanks.

@Infocatcher
Copy link
Owner

Infocatcher commented Apr 30, 2017

May be something was already corrected in latest Nightly... Looks like all fine for me at least after restarts.
Can you provide some steps to reproduce this bug?

@C4rb0n
Copy link
Author

C4rb0n commented May 1, 2017

Bug definitely still exists. Did you make sure to disable multi-process before testing?
Here are steps:

  1. Grab the latest Firefox nightly build (I'm using the 64-bit Windows build).
  2. Launch Firefox and go to: Options --> General.
  3. Under "Startup," for When Nightly starts, choose "Show your windows and tabs from last time"
  4. Again, under "Startup," uncheck "Enable multi-process Nightly" and restart the browser
  5. Install Private Tab extension
  6. Browse and open up about 30 tabs to various websites on the Internet.
  7. Restart Firefox.
    You should find that most of your tabs permanently show up as "about:blank"

@jedie
Copy link

jedie commented May 15, 2017

confirm this bug with firefox ESR v52.1.1

disable/enable fix it temporary

@B00ze64
Copy link

B00ze64 commented May 30, 2017

This was also reported on TabGroups GitHub; @C4rb0n Are you also using TabGroups?

@C4rb0n
Copy link
Author

C4rb0n commented May 30, 2017

Nope. Don't use TabGroups.

@B00ze64
Copy link

B00ze64 commented Sep 10, 2017

@jedie Are you sure this bug affects ESR 52.1.1? I'm about to update to 52 from 45 and worried, so I went ahead and read the whole bug 1345090 and it clearly states this is not uplifted to 52, and landed in FF55 only. For safety I added this to my user.js: user_pref("browser.sessionstore.restore_tabs_lazily", false);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants