Usernames and database names have to be quoted. #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's legal for databases and users to have odd characters that require quoting. This is done in some parts of the code but not others. I think I found all the places where the quoting needs to happen but I would appreciate a look over.
Errors
Hopefully some other poor soul won't have waste time finding this out the hard way. So here's some error dumps that search engines might key onto if your database has a
-
in it.