Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome property not updating #85

Open
ThatForkyDev opened this issue Nov 2, 2023 · 1 comment
Open

Biome property not updating #85

ThatForkyDev opened this issue Nov 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ThatForkyDev
Copy link

ThatForkyDev commented Nov 2, 2023

Describe the issue
Default biome property not functioning correctly

Spigot version
1.20.2

Plugin version
2.10.0

How to reproduce
Import a world, I did a nether one so your biome is going to be crimson_forest or similar, then fly out, and after you're out of the render distance it will show it as plains which removes all the effects from being in the nether.

This was based off the property map in worlds (templates)

Upon loading I also tried the following

    private final Map<Environment, String> biomes = new HashMap<>() {{
        super.put(Environment.NORMAL, "minecraft:plains");
        super.put(Environment.THE_END, "minecraft:the_end");
        super.put(Environment.NETHER, "minecraft:crimson_forest");
    }};


//method
try {
            if (this.mongoLoader.isWorldLocked(key)) { //big sad
                this.mongoLoader.unlockWorld(key);
            }

            final SlimePropertyMap slimePropertyMap = new SlimePropertyMap();
            slimePropertyMap.setValue(SlimeProperties.DEFAULT_BIOME, this.biomes.get(environment));
            slimePropertyMap.setValue(SlimeProperties.ENVIRONMENT, environment.name());

            final SlimeWorld slimeWorld = this.slimePlugin.loadWorld(this.mongoLoader, key, false, slimePropertyMap);
} //catch clauses

image
@ThatForkyDev ThatForkyDev added the bug Something isn't working label Nov 2, 2023
@kyngs
Copy link
Member

kyngs commented Jan 17, 2024

As far as I know, SWM doesn't really support biomes? @Paul19988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants