Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: increase size of 'X' in ggcorrmat? #579

Closed
kevinrue opened this issue Apr 21, 2021 · 2 comments
Closed

JOSS review: increase size of 'X' in ggcorrmat? #579

kevinrue opened this issue Apr 21, 2021 · 2 comments
Labels
enhancement 🔥 New feature or request

Comments

@kevinrue
Copy link

More of a question than a suggestion:

How about increasing the 'X' that marks non-significant correlations?

Right now, it's actually a bit difficult to spot the X's because they're about the same size at the correlation value.

I'm wondering whether making the 'X' bigger would achieve two benefits:

  • easier to spot the X's
  • easier to read the non-significant correlation values (for what they're worth ...) that are hidden behind those X's

For openjournals/joss-reviews#3167

@IndrajeetPatil IndrajeetPatil added the enhancement 🔥 New feature or request label Apr 21, 2021
@IndrajeetPatil
Copy link
Owner

Thanks for the suggestion. This is a good point. Here is the changed behavior:

# for reproducibility
set.seed(123)
library(ggstatsplot)

ggcorrmat(
  data = ggplot2::msleep,
  colors = c("#B2182B", "white", "#4D4D4D"),
  title = "Correlalogram for mammals sleep dataset",
  subtitle = "sleep units: hours; weight units: kilograms"
)

Created on 2021-04-21 by the reprex package (v2.0.0)

@kevinrue
Copy link
Author

Brilliant! I think it looks great now. I hope you agree as the developer, but as a user I find it both clearer to spot the X's and more readable (the numbers behind the X's).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants