Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS review: clarity of supported features table in README #575

Closed
kevinrue opened this issue Apr 21, 2021 · 0 comments
Closed

JOSS review: clarity of supported features table in README #575

kevinrue opened this issue Apr 21, 2021 · 0 comments
Labels
documentation 📑 Error/problems with documentation

Comments

@kevinrue
Copy link

ggstatsplot/README.Rmd

Line 159 in 22e7a84

`ggbetweenstats` | Between group/condition comparisons | <font color="green">Yes</font> | <font color="green">Yes</font> | <font color="green">Yes</font> | <font color="green">Yes</font>

Currently, there is little contrast between "Yes" and NA in this table.

I suggest using icons, as it is done further below (e.g. section "Defaults return").

For instance, you could:

  • replace "Yes" by ✅
  • replace "NA" by ❌

Which would instantly visually distinguish features that are supported from those that aren't yet.

For openjournals/joss-reviews#3167
@IndrajeetPatil IndrajeetPatil added the documentation 📑 Error/problems with documentation label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation 📑 Error/problems with documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinrue @IndrajeetPatil