Added GLORIA parser in tools.ioparser #139
Open
+2,543
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any plans to pull this in? We would find access to GLORIA to be quite useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #128
A parser for GLORIA was coded following Issue #128 , 3 functions were coded, one to read GLORIA in its original SUT structure, one (__construct_IO) to construct the IO matrices from the SUT ones, and a final one (the parse_gloria that users should call) that uses the two previous ones and returns an IOSystem.
The __construct_IO is quite useless for GLORIA as I came to realize that the supply matrix in GLORIA is diagonal (commodities and industries match one to one), but it can be used in the future to parse other SUT databases into pymrio. The __construct_IO function can build the IO matrices from the SUT using one of the four models described in Miller Blair 2009.
I also added a (very) simple test and a mock gloria, it only tests that parsing gloria with all possible parameters works.