Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.8.b - Getting error notification for background updates when in flight mode #55

Closed
rak-rak opened this issue Oct 10, 2022 · 18 comments
Labels
bug Something isn't working needs follow up Further information is requested

Comments

@rak-rak
Copy link

rak-rak commented Oct 10, 2022

Backup update checking interval is set. When at night the flight mode of the device is enabled, I will get a error notification.

I would expect that Obtainium waits until there is a data connection (WiFi or mobile).
(Tested on Android 12)

@ImranR98
Copy link
Owner

It's supposed to. I left a phone on airplane mode for about 7 hours (interval 1 hour) and did not see any errors (checking logs confirmed that update checking did not run). Once I disabled airplane mode, it ran the task, so I haven't been able to reproduce the error.
What exact error message do you get? How many Apps do you have?

@ImranR98 ImranR98 added bug Something isn't working needs follow up Further information is requested labels Oct 10, 2022
@S7venLights
Copy link

S7venLights commented Oct 10, 2022

It may be a notification for when obtainium finds no updates, as mentioned in issue #47

@rak-rak
Copy link
Author

rak-rak commented Oct 11, 2022

I have 12 apps in Obtainium. 11 from github.com, 1 from f-droid.

This is the error message in the morning when in flight mode during night:

"Error checking for updates
Failed host lookup" api.github.com' "

Screenshot: https://bilderupload.org/image/a7d971449-screenshot-20221011-08492.png

@S7venLights
Copy link

Oh i've seen that error too when disconnected, but thought nothing of it because I knew why it was happening.

@S7venLights
Copy link

S7venLights commented Oct 12, 2022

By the way I left my phone on last night but with no data connection in airplane mode. Got this error over night: Error checking for updates, Failed host lookup: 'api.github.com' (Correction, I may have got that error when I connected to wifi this morning but the VPN was still connecting)

@rak-rak
Copy link
Author

rak-rak commented Oct 12, 2022

Tested now. v0.5.9-beta:
The error message itself was improved, see screenshot: https://bilderupload.org/image/d34a56323-screenshot-20221012-07504.png

But it still shows up, the issue persists. Usually an app should not show error messages, when there is no data connection. Imagine every app would show such error messages in flight mode. ;)

Didn't test v0.5.8.10-beta. But this issue seems to be still open.

@ImranR98
Copy link
Owner

What version of Android is it? I can't replicate the issue on Android 13, will try with older versions.

@rak-rak
Copy link
Author

rak-rak commented Oct 12, 2022

As mentioned in first post: I'm using Android 12 (Samsung Tab S6).

@ImranR98
Copy link
Owner

Sorry, missed that. @S7venLights wouls be useful to know if you're also on 12/Samsung

@S7venLights
Copy link

I'm on 12 pixel graphene OS but I'm not getting the errors he's getting.

@ImranR98
Copy link
Owner

I was not able to replicate this either, on a stock Android 10 emulator this time. It should respect the work constraints which are set for the update task, but that's not happening in your case @rak-rak. I think this may be a device-specific bug, let's see if anyone else reports it.

@S7venLights
Copy link

Well I did get the error once or twice but I think now it only happens, when wifi turns on but the VPN is still getting connection. Will see tomorrow morning

@rak-rak
Copy link
Author

rak-rak commented Oct 13, 2022

Tested on another device: Samsung S22 (Android 12). Same configuration.

And didn't get an error notification.

@ImranR98
Copy link
Owner

Between my Android 10 and 13 emulators, S7Lights' Pixel 3, and rak-rak's S22 and Tab, this error only seems to consistently show up on the tablet. So I'll close this in a few days as a device bug that the Obtainium can't do much to fix, unless it shows up on other devices.
You could maybe see if this bug shows up on your tablet with other Apps that use Android's WorkManager for periodic tasks (maybe Tasker or something like it, not sure).

@S7venLights
Copy link

Һаѕո't happened for me lately

@rak-rak
Copy link
Author

rak-rak commented Oct 15, 2022

Got the same error notification now on phone Samsung S22: https://bilderupload.org/image/764716928-screenshot-20221015-08470.jpg

Maybe important: Battery optimzation for Obtainium is disabled.

@ImranR98
Copy link
Owner

This is likely fixed in the latest version: https://github.com/ImranR98/Obtainium/releases/tag/v0.6.0-beta

I'm not 100% sure since you had this issue before the changes in 0.6.0, but please give it a try. Will re-open this issue if needed.

@rak-rak
Copy link
Author

rak-rak commented Oct 31, 2022

No more error notifications forum 2 nights now. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs follow up Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants