Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably using league/container was not very good idea #1421

Open
MekDrop opened this issue Mar 1, 2023 · 2 comments
Open

Probably using league/container was not very good idea #1421

MekDrop opened this issue Mar 1, 2023 · 2 comments
Labels

Comments

@MekDrop
Copy link
Member

MekDrop commented Mar 1, 2023

If a module rewrites or extends some core functionality, it sadly doesn't work. If module tries to redefine a service it hangs up.

It seems league/container doesn't supports such possibilities.

Probably replacing with symfony/container would be safest bet to solve this.

Such functionality should solve issue how to turn such things like formulize into normal modules again and move some core functionality to modules.

@MekDrop MekDrop added the bug label Mar 1, 2023
@MekDrop MekDrop added this to the ImpressTNG Alpha 13 milestone Mar 1, 2023
@fiammybe
Copy link
Member

fiammybe commented Mar 1, 2023

ouch, didn't see that one coming. If you think that symfony/container will solve that issue, that might be a safe bet (half the PHP world uses that one). I can imagine that will be a huge PR, migrating from league/container to symfony/container?

@MekDrop
Copy link
Member Author

MekDrop commented Mar 1, 2023

Probably not very huge (requires only few file changes) but still some extra work :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants