Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streetcover bug #258

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Streetcover bug #258

merged 7 commits into from
Sep 18, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Aug 5, 2024

Description

Found some oddly formatted lanes entries. This fixes it.

TODO:

@barneydobson barneydobson added the bug Something isn't working label Aug 5, 2024
@cheginit
Copy link
Collaborator

I am not sure about this ad-hoc solution. I'd suggest solving the issue at its source, i.e., add a new post-processing step for the street graph to ensure that lane's edge attribute is an int.

@barneydobson
Copy link
Collaborator Author

I am not sure about this ad-hoc solution. I'd suggest solving the issue at its source, i.e., add a new post-processing step for the street graph to ensure that lane's edge attribute is an int.

Yep good suggestion - I'll look at next week

@@ -136,6 +137,23 @@ def __call__(
return G


def sum_over_delimiter(s):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs appropriate typing to include the case of the input not being a string, and update the docstring, accordingly. If it is not a string, what would it be? Output typing also needs updating.

@barneydobson
Copy link
Collaborator Author

I am not sure about this ad-hoc solution. I'd suggest solving the issue at its source, i.e., add a new post-processing step for the street graph to ensure that lane's edge attribute is an int.

this will require a bit more than I want to do in this PR so I will make a new issue

@barneydobson barneydobson merged commit 174eb14 into main Sep 18, 2024
8 checks passed
@barneydobson barneydobson deleted the streetcover-edit branch September 18, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants