Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create_model to iterate over registered functions that take graphs and give graphs #8

Closed
barneydobson opened this issue Jan 18, 2024 · 0 comments
Assignees
Labels
enhancements refactor Refactoring existing code without significantly changing functionality

Comments

@barneydobson
Copy link
Collaborator

Preferred function format will follow the format:

@register_graphfcn
def generic_function(G, a, b, **kwargs):

    # create G_ from G, a, b
    return G_

And create_model will primarily call:

for function in list_of_functions 
    G = function(G, **parameters, **addresses)
    if verbose:
        graph_to_geojson(G, function.__name__ + .geojson)
save_graph(G, function.__name__ + .json)
@barneydobson barneydobson added refactor Refactoring existing code without significantly changing functionality enhancements priority! labels Jan 18, 2024
@barneydobson barneydobson self-assigned this Jan 19, 2024
This was referenced Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements refactor Refactoring existing code without significantly changing functionality
Projects
None yet
Development

No branches or pull requests

1 participant