Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of interpolation in comparing real/synthetic simulation timeseries #76

Open
barneydobson opened this issue Mar 7, 2024 · 0 comments
Assignees
Labels
sa_paper Sensitivity analysis paper

Comments

@barneydobson
Copy link
Collaborator

barneydobson commented Mar 7, 2024

I don't think it makes sense to interpolate missing data before computing NSE, I think it makes more sense to just drop those dates and compute NSE for the rest.

Originally posted by @cheginit in #60 (comment)

My concern is that SWMM timesteps can be selected by the solver on the fly (i.e., whether it is dry or not) - and so there is a risk that there will be no perfectly overlapping datapoints if the synthetic and real simulation solvers get out of sync.
However, and probably the intuitive basis of your concern, is that if someone ramped up the DRY_STEP or REPORT_STEP values in the .inp file to increase speed, this interpolation could cause some significant issues.
Ultimately I think this is probably too complicated to fix here and needs its own issue, and ideally some simulations we can look at to see the balance of risks here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sa_paper Sensitivity analysis paper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant