Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using the bounds in the IntoProposal trait for into path bounds #267

Open
f-gate opened this issue Nov 7, 2023 · 0 comments
Open

Consider using the bounds in the IntoProposal trait for into path bounds #267

f-gate opened this issue Nov 7, 2023 · 0 comments
Labels
Priority | Medium refactor Refactoring is required

Comments

@f-gate
Copy link
Member

f-gate commented Nov 7, 2023

The current problem is that in pallet-briefs and pallet-grants i have to rebind the bounds of inputs for conversion to a project to match that of IntoProposal::convert_to_proposal this is obviously not ideal. Another issue surrounding this is we have 3 locations where max milestones is defined. Ofc this has been covered by the sanity tests but if we use the bound of the IntoProposal's associated types we dont have to do these checks.

Its a nice to have for sure
@f-gate f-gate added refactor Refactoring is required Priority | Medium labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority | Medium refactor Refactoring is required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@f-gate