-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make background transparent for binary segmentations #245
Comments
Per discussion elsewhere, for now let's just remove it. We can consider adding opacity controls for background later, if there is a need. It is not critical, but difficult to implement. |
@fedorov PR merged. Please test using gha's deploy-slim-with-dmv action. |
Let's remove the color bar whenever segmentation is binary (it is defined by |
Here's is a sample of fractional segmentations: Let's add a toggle to visualize background. We need to confirm what is the range of actual values that are present in the fractional SEGs in the sample above (ie, is it just 255 and 0, or it's a range). We need to know whether what is shown in the overlay is everything that is non-zero, or there is some threshold involved. We need to confirm if for the fractional SEG above there is a preferred color assigned per-segment, and if yes - whether the color palette assigned to the segment overlay is based on that assigned color. |
@fedorov I'm getting a 204 (No Content) response from the server when querying for studies: |
I am not sure what this means. I confirmed you have the permissions on that store. |
It's as if the store is empty (no studies). Can you confirm that it is up to date and exposing the fractional segmentations study you mentioned? |
@pedrokohler you can test fractional with this example https://viewers-sandbox-gha-testing.web.app/studies/2.25.196582159794535790494756475166017942942/series/1.3.6.1.4.1.5962.99.1.3160775297.310520648.1686787988097.4.0. I think we need to have answers to the questions asked earlier:
|
Example: https://healthcare.googleapis.com/v1/projects/idc-sandbox-000/locations/us-central1/datasets/fedorov-dev-healthcare/dicomStores/singlebitsegstest/dicomWeb (limited access).
Currently, it is impossible to change opacity of the background without changing the opacity of the foreground. We need to have same functionality as while showing segmentations in OHIF.
The text was updated successfully, but these errors were encountered: