-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SRs Class-Based Annotation Toggle #193
Comments
@fedorov please confirm if the solution I'm proposing makes sense for your needs: I'm thinking we can maybe add a Annotation Type menu together with the ones in the picture below: In this menu we'd have all of the types of the SRs loaded. Then with a toggle button you can disable or enable all of them at once. Something similar to this: Let me know if that works. |
How about we add "Property types" and "Property categories" sections under "Annotation groups", list all distinct types/properties under those along with the toggles, and use the same text as we use for those attributes in the individual annotation groups? |
Just to clarify, you're envisioning something like the following then, @fedorov? Suppose you have these Annotation Groups: You'd then also have these two sections which would look like the image below: Is that it? In this case me and Igor were discussing and we think the best option in case of conflict (suppose the 'type' one is turned on and the 'category' one is turned off), then the 'off' always wins... meaning that if you either turn off the type or the category, then the annotations that match either one will disappear, no matter is the remaining section says otherwise. For the sake of an example, suppose the following scenario: Annotation 1 - Type A, Category X Type A - OFF Category X - OFF In this case none of the annotations would be visible, even though Type B and Category Y are turned on, because the 'off' switch has precedence. Hope I made myself clear. Please let me know if that works. |
How hard would it be to implement a three-state switch or checkbox for categories, as shown below? From what I understand (from how the data is encoded), category can include one or more types, BUT type can belong to one and only one category. So in your example, if Type A is switched off, Type B would be still on, and it would make sense to show Category X as partially enabled. If this is too difficult to understand or implement - I am fine with your approach, and we can revisit after the initial implementation! |
Implement Class-Based Annotation Toggle
Description
Introduce a feature to enable or disable annotations for a specific class of SR objects simultaneously. Each SR object belongs to a class (e.g., ERMS, ARMS, connective tissue, etc.), and providing the capability to toggle annotations for a particular class will enhance user control and streamline workflow efficiency.
Acceptance Criteria
From #184
The text was updated successfully, but these errors were encountered: