Installed s5cmd should be used and not the system

[fedorov]

Currently, which is used to locate s5cmd binary. Instead, we should use the one installed as a prerequisite.

[jcfr]

The fallback approach could then be the one we always use:

idc-index/idc_index/index.py

Lines 45 to 55 in f78a7dc

	# Lookup s5cmd
	self.s5cmdPath = shutil.which("s5cmd")
	if self.s5cmdPath is None:
	# Workaround to support environment without a properly setup PATH
	# See https://github.com/Slicer/Slicer/pull/7587
	logger.debug("Falling back to looking up s5cmd along side the package")
	for script in distribution("s5cmd").files:
	if str(script).startswith("s5cmd/bin/s5cmd"):
	self.s5cmdPath = script.locate().resolve(strict=True)
	break

Is the use of which failing in the case where the environment has not been activated ?

[fedorov]

I would prefer to use the fallback as primary, since there may be s5cmd version incompatibility. Is there any problem with that approach?

[fedorov]

Is the use of which failing in the case where the environment has not been activated ?

It is not failing, but it is picking s5cmd from outside of the python distribution within Slicer. This came up while debugging a different issue with SlicerIDCBrowser, which is using idc-index.