diff --git a/src/ng/directive/ngRepeat.js b/src/ng/directive/ngRepeat.js index 893ad442e1b4..c59fefacc956 100644 --- a/src/ng/directive/ngRepeat.js +++ b/src/ng/directive/ngRepeat.js @@ -92,14 +92,17 @@ var ngRepeatDirective = ngDirective({ scope.$watch(function ngRepeatWatch(scope){ var index, length, collection = scope.$eval(rhs), - collectionLength = size(collection, true), - childScope, + cursor = iterStartElement, // current position of the node // Same as lastOrder but it has the current state. It will become the // lastOrder on the next iteration. nextOrder = new HashQueueMap(), + arrayLength, + childScope, key, value, // key/value of iteration - array, last, // last object information {scope, element, index} - cursor = iterStartElement; // current position of the node + array, + last; // last object information {scope, element, index} + + if (!isArray(collection)) { // if object, extract keys, sort them and use to determine order of iteration over obj props @@ -114,6 +117,8 @@ var ngRepeatDirective = ngDirective({ array = collection || []; } + arrayLength = array.length; + // we are not using forEach for perf reasons (trying to avoid #call) for (index = 0, length = array.length; index < length; index++) { key = (collection === array) ? index : array[index]; @@ -149,7 +154,7 @@ var ngRepeatDirective = ngDirective({ childScope.$index = index; childScope.$first = (index === 0); - childScope.$last = (index === (collectionLength - 1)); + childScope.$last = (index === (arrayLength - 1)); childScope.$middle = !(childScope.$first || childScope.$last); if (!last) { diff --git a/test/ng/directive/ngRepeatSpec.js b/test/ng/directive/ngRepeatSpec.js index de8aa8618871..33e4dcfd0464 100644 --- a/test/ng/directive/ngRepeatSpec.js +++ b/test/ng/directive/ngRepeatSpec.js @@ -274,7 +274,7 @@ describe('ngRepeat', function() { '')(scope); - scope.items = {'misko':'m', 'shyam':'s', 'doug':'d', 'frodo':'f', '$internal': 'xxxx'}; + scope.items = {'misko':'m', 'shyam':'s', 'doug':'d', 'frodo':'f'}; scope.$digest(); expect(element.text()). toEqual('doug:d:true-false-false|' + @@ -293,6 +293,21 @@ describe('ngRepeat', function() { }); + it('should calculate $first, $middle and $last when we filter out properties from an obj', function() { + element = $compile( + '')(scope); + scope.items = {'misko':'m', 'shyam':'s', 'doug':'d', 'frodo':'f', '$toBeFilteredOut': 'xxxx'}; + scope.$digest(); + expect(element.text()). + toEqual('doug:d:true-false-false|' + + 'frodo:f:false-true-false|' + + 'misko:m:false-true-false|' + + 'shyam:s:false-false-true|'); + }); + + it('should ignore $ and $$ properties', function() { element = $compile('')(scope); scope.items = ['a', 'b', 'c'];