Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab component - Unify implementation in a single component #504

Open
rkaraivanov opened this issue Sep 8, 2022 · 0 comments
Open

Tab component - Unify implementation in a single component #504

rkaraivanov opened this issue Sep 8, 2022 · 0 comments

Comments

@rkaraivanov
Copy link
Member

Description

When the tabs were implemented, due to the way slot projection work, we took the approach to have separate header and panel components for each tab.

However, this creates problems for accessibility and ease of use from a developer point of view.

I suggest refactoring the tab into a single <igc-tab> component with the appropriate slots for header/content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants