Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline Property interferes with the type is search #1502

Closed
desig9stein opened this issue Dec 3, 2024 · 0 comments · Fixed by #1520
Closed

Outline Property interferes with the type is search #1502

desig9stein opened this issue Dec 3, 2024 · 0 comments · Fixed by #1520
Assignees

Comments

@desig9stein
Copy link
Contributor

Which component(s) are affected?

Input

Description

Since there are no dedicated outline-search or box-search styles, the <igc-input>'s outlined property conflicts with the type="search" attribute. This results in unintended styling when the input type is set to search.

To address this issue, one potential solution is to update the component's styles to ignore the outlined and box styles when the type is set to search. Alternatively, the outlined property can be programmatically disabled in the component's logic to prevent any interference.

In either case, it's important to clarify to users that if they set the type attribute to search, the outlined property will be ignored to ensure proper visual consistency and alignment with expected design.

Reproduction

  1. Add an component to a page.
  2. Set the type attribute of the component to "search".
  3. Set the outlined property of the component to true.
  4. Observe that the input styles are visually inconsistent or broken due to a conflict between the outlined property and the type="search" attribute styles.

Workaround

Don't use the outlined property if the input type is set to search

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

All

Browser/OS/Node environment

All

@desig9stein desig9stein added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Dec 3, 2024
@simeonoff simeonoff assigned desig9stein and unassigned simeonoff Dec 11, 2024
@simeonoff simeonoff added ✅ status: resolved and removed 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants