Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): aria-label issue #1439

Closed
wants to merge 2 commits into from
Closed

fix(slider): aria-label issue #1439

wants to merge 2 commits into from

Conversation

SisIvanova
Copy link
Contributor

Closes #1410

@SisIvanova SisIvanova added a11y When the issue or PR is related to accessibility ❌ status: awaiting-test slider labels Oct 17, 2024
@SisIvanova SisIvanova requested a review from simeonoff October 17, 2024 08:46
@simeonoff
Copy link
Collaborator

@SisIvanova we will have to defer this fix as after some discussion with @rkaraivanov, we would like to implement a different solution that will solve this and other issues in the component.

@simeonoff simeonoff closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@simeonoff simeonoff

@georgianastasov georgianastasov

Labels
a11y When the issue or PR is related to accessibility DO-NOT-MERGE slider ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect aria-label implementation on igc-slider component
3 participants
@SisIvanova @simeonoff @georgianastasov