Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended FAB text style is not working properly on Paragraph html element #3034

Closed
zdrawku opened this issue Nov 19, 2021 · 5 comments
Closed
Assignees

Comments

@zdrawku
Copy link
Contributor

zdrawku commented Nov 19, 2021

Description

According to the documentation:

To get the extended FAB text styled properly, use <span>, <div> or <p> tags.

Although with Paragraphs the styling result in:

image

  • igniteui-angular version: latest
  • browser: any

Steps to reproduce

  1. Open the sample
  2. Check the P style

Result

image

Expected result

image

@desig9stein
Copy link
Contributor

@zdrawku, @simeonoff I think that we should update the documentation and not encourage people to use <p> inside <button> Since this is not allowed and HTML validators will throw an error. However, I can still update the button styles to make sure that if the user uses p,h1...h6, strong... the bottom will look ok. Let me know what you guys think.

@simeonoff simeonoff transferred this issue from IgniteUI/igniteui-angular Nov 22, 2021
@simeonoff
Copy link
Collaborator

@zdrawku, @simeonoff I think that we should update the documentation and not encourage people to use <p> inside <button> Since this is not allowed and HTML validators will throw an error. However, I can still update the button styles to make sure that if the user uses p,h1...h6, strong... the bottom will look ok. Let me know what you guys think.

I agree. Update the documentation to reflect your comment.

@desig9stein
Copy link
Contributor

@zdrawku, @simeonoff I think that we should update the documentation and not encourage people to use <p> inside <button> Since this is not allowed and HTML validators will throw an error. However, I can still update the button styles to make sure that if the user uses p,h1...h6, strong... the bottom will look ok. Let me know what you guys think.

I agree. Update the documentation to reflect your comment.

I know that the igxButton directive can be set to any element, not just a button. This means that the following example is valid. I know that it doesn't make much sense but it is a valid scenario.

<div igxButton>
   <p>test</p>
</div>

Do you want me to update only the docs or also the button styles?

@simeonoff
Copy link
Collaborator

Just the docs.

@zdrawku
Copy link
Contributor Author

zdrawku commented Nov 25, 2021

@zdrawku zdrawku closed this as completed Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants