Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grid): add new directives for re-templating header sorting indicators #10394

Merged
merged 12 commits into from
Nov 10, 2021
Merged

feat(grid): add new directives for re-templating header sorting indicators #10394

merged 12 commits into from
Nov 10, 2021

Conversation

viktorkombov
Copy link
Contributor

Closes #10217

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

hanastasov
hanastasov previously approved these changes Nov 3, 2021
View reviewed changes
kacheshmarova
kacheshmarova previously approved these changes Nov 3, 2021
View reviewed changes
@kacheshmarova kacheshmarova marked this pull request as ready for review November 3, 2021 14:32
@kacheshmarova kacheshmarova added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 3, 2021
@ddaribo ddaribo added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 4, 2021
@viktorkombov viktorkombov dismissed stale reviews from kacheshmarova and hanastasov via 1a3d1b0 November 4, 2021 08:17
kacheshmarova
kacheshmarova previously approved these changes Nov 4, 2021
View reviewed changes
hanastasov
hanastasov previously approved these changes Nov 8, 2021
View reviewed changes
@ddaribo ddaribo added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 8, 2021
@viktorkombov viktorkombov dismissed stale reviews from hanastasov and kacheshmarova via 8038f29 November 9, 2021 11:56
@kdinev
Copy link
Member

kdinev commented Nov 10, 2021

@viktorkombov Please resolve conflicts before the review.

@teodosiah teodosiah merged commit f91a32f into master Nov 10, 2021
@teodosiah teodosiah deleted the vkombov/feat-10217-master branch November 10, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov approved these changes

@kacheshmarova kacheshmarova kacheshmarova approved these changes

@simeonoff simeonoff simeonoff approved these changes

@kdinev kdinev kdinev approved these changes

Assignees

@kacheshmarova kacheshmarova

@ddaribo ddaribo

Labels
grid: general grid: sorting version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Igx Grid Sort Icon Change
7 participants
@viktorkombov @kdinev @simeonoff @kacheshmarova @hanastasov @ddaribo @teodosiah