IgxStepperComponent implementaton #10061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaribo
force-pushed
the
thristodorova/stepper-implementaton
branch
from
27034e8 to
d9e4a8c
Compare
mmart1n
force-pushed
the
thristodorova/stepper-implementaton
branch
from
0174e71 to
88875aa
Compare
desig9stein
force-pushed
the
thristodorova/stepper-implementaton
branch
from
bc8daa2 to
b29cecc
Compare
MonikaKirkova
force-pushed
the
thristodorova/stepper-implementaton
branch
from
470084a to
349867d
Compare
mmart1n
force-pushed
the
thristodorova/stepper-implementaton
branch
from
def06c1 to
7cd0583
Compare
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/stepper/step/step.component.ts
Outdated
Show resolved
Hide resolved
teodosiah
added
❌ status: awaiting-test
simeonoff
previously requested changes
Oct 15, 2021
projects/igniteui-angular/src/lib/core/styles/components/stepper/_stepper-component.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_stepper.scss
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/core/styles/themes/schemas/shape/_stepper.scss
Outdated
Show resolved
Hide resolved
wnvko
requested changes
Oct 19, 2021
wnvko
requested changes
Oct 21, 2021
wnvko
requested changes
Oct 22, 2021
wnvko
previously approved these changes
Oct 28, 2021
jackofdiamond5
previously approved these changes
Oct 28, 2021
There was a problem hiding this comment.
We should make small changes to the changelog and the readme, to make sure that all the code snippets are aligned and the API is documented consistently. Additionally, as @wnvko said we should consider moving the logic in the steps to be part of the stepper, so that the individual steps do not know of the stepper component but this is internal and we can do it in a different PR. Other than that I think this is good to go.
mmart1n
force-pushed
the
thristodorova/stepper-implementaton
branch
2 times, most recently
from
90d578a to
555088c
Compare
Co-authored-by: Marin Popov <[email protected]>
Co-authored-by: Teodosia Hristodorova <[email protected]>
- add leaveAnimationDone and enterAnimationDone events - rename animationDuration Co-authored-by: MonikaKirkova <[email protected]>
mmart1n
force-pushed
the
thristodorova/stepper-implementaton
branch
from
555088c to
e37a358
Compare
jackofdiamond5
previously approved these changes
Oct 28, 2021
teodosiah
added
✅ status: verified
Co-authored-by: Bozhidara Pachilova <[email protected]>
IgxStepper tests
jackofdiamond5
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8667
Closes #10349
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)