Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snackbar should implement IToggleView #9677

Closed
VladB93 opened this issue Jun 8, 2021 · 0 comments · Fixed by #9733
Closed

Snackbar should implement IToggleView #9677

VladB93 opened this issue Jun 8, 2021 · 0 comments · Fixed by #9733
Assignees
@kdinev @simeonoff
Labels
snackbar toggle 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@VladB93
Copy link
Contributor

VladB93 commented Jun 8, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Currently the snackbar supports open/close methods, but it's not togglable - there is no toggle method and other components can't toggle it through igxToggleAction.

Describe the solution you'd like

Snackbar implementing the IToggleView interface.

Describe alternatives you've considered

Additional context

It would also be nice to have the snackbar project its content in overlay. Currently it projects the content relative to the snackbar component itself.
@simeonoff simeonoff added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 14, 2021
@SisIvanova SisIvanova mentioned this issue Jun 16, 2021
Merged
14 tasks
@SisIvanova SisIvanova linked a pull request Jun 16, 2021 that will close this issue
refactor(snackbar): should implement IToggleView #9733
Merged
14 tasks
@SisIvanova SisIvanova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 25, 2021
@SisIvanova SisIvanova mentioned this issue Jun 30, 2021
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdinev kdinev

@simeonoff simeonoff

Labels
snackbar toggle 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(snackbar): should implement IToggleView IgniteUI/igniteui-angular
4 participants
@kdinev @simeonoff @VladB93 @SisIvanova