Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupBy selection optimization #9405

Closed
mmart1n opened this issue Apr 23, 2021 · 4 comments
Closed

GroupBy selection optimization #9405

mmart1n opened this issue Apr 23, 2021 · 4 comments

Comments

@mmart1n
Copy link
Contributor

mmart1n commented Apr 23, 2021

Description

Currently the group by selection doesn't use any caching mechanism which leads to poor performance when selecting larger groups.

  • igniteui-angular version: 11.1.x, 12.1.x
  • browser: any

Steps to reproduce

  1. Open the following sample
  2. Group by the Field column
  3. Select the Field: some text group

Result

There is a slight delay until all the records in the group get selected.

Expected result

There shouldn't be a delay.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jun 26, 2021
@github-actions github-actions bot closed this as completed Jul 3, 2021
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Jul 5, 2021
@radomirchev radomirchev reopened this Jul 5, 2021
@Timmeeeey
Copy link

For me it's more than just a slight delay (see example).

https://stackblitz.com/edit/github-hwxmub

If you group by 'category' and select any group the page doesn't respond anymore.
This could be related to #9250.

  • igniteui-angular version: 12.0.7

@damyanpetev
Copy link
Member

@Timmeeeey That's correct, part of the delay (about a third by my perf logs) is due to emitting a ton of events in these cases caused by #9250.
There was an easy fix for this issue that'll greatly reduce the time, though with as much group records as in your case it still isn't enough. So we'll address the events next as soon as possible.

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Nov 7, 2021
@ChronosSF ChronosSF removed the status: inactive Used to stale issues and pull requests label Nov 8, 2021
@kacheshmarova kacheshmarova removed their assignment Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants