Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding element with ngIf in igxRowEditText template throws error #9131

Closed
mddragnev opened this issue Mar 11, 2021 · 7 comments · Fixed by #11234
Closed

Adding element with ngIf in igxRowEditText template throws error #9131

mddragnev opened this issue Mar 11, 2021 · 7 comments · Fixed by #11234
Assignees
Labels
🐛 bug Any issue that describes a bug grid: row-editing ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@mddragnev
Copy link
Member

Description

Having row edit text template as child in a grid causes an error. The error is probably some detection cycle for the columns.

  • igniteui-angular version:
  • browser:

Steps to reproduce

  1. Open any dev row editing sample
  2. As a child of the grid add a template of row edit text with any element with ngIf within.
    <ng-template igxRowEditText> <div *ngIf="5>2"> Test </div> </ng-template>

Result

Observe the error thrown in the console when loading the sample.
image

Expected result

No error should be thrown

@mddragnev mddragnev added 🐛 bug Any issue that describes a bug grid: row-editing labels Mar 11, 2021
@ChronosSF ChronosSF assigned ChronosSF and radomirchev and unassigned ChronosSF Mar 22, 2021
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 26, 2021
@github-actions github-actions bot closed this as completed Jun 2, 2021
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Jun 3, 2021
@radomirchev radomirchev assigned ChronosSF and unassigned radomirchev Jun 3, 2021
@radomirchev radomirchev reopened this Jun 3, 2021
@DeniseCP
Copy link

Hi guys, so I have a error related on v 12.0.4
After adding a new line I get an error

ERROR TypeError: Cannot add property 6, object is not extensible at Array.push (<anonymous>) at IgxGridAPIService.addRowToData (igniteui-angular.js:29294) at IgxGridCRUDService.endAdd (igniteui-angular.js:28972) at IgxGridCRUDService.endEdit (igniteui-angular.js:28776) at IgxGridComponent.endEdit (igniteui-angular.js:61490) at PortfolioMaintenanceComponent_ng_template_24_Template_button_click_4_listener (portfolio-maintenance.component.html:49) at executeListenerWithErrorHandling (core.js:15275) at wrapListenerIn_markDirtyAndPreventDefault (core.js:15319) at HTMLButtonElement.<anonymous> (platform-browser.js:560) at ZoneDelegate.invokeTask (zone.js:406)

And I get a ui error too

image

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 16, 2021
@ChronosSF ChronosSF removed the status: inactive Used to stale issues and pull requests label Aug 16, 2021
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Oct 16, 2021
@ChronosSF ChronosSF removed the status: inactive Used to stale issues and pull requests label Oct 18, 2021
@ChronosSF ChronosSF assigned dkamburov and unassigned ChronosSF Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jan 8, 2022
@radomirchev radomirchev assigned dkamburov and unassigned dkamburov Jan 10, 2022
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Jan 10, 2022
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Mar 12, 2022
@dkamburov dkamburov removed the status: inactive Used to stale issues and pull requests label Mar 14, 2022
@mddragnev mddragnev added the 🛠️ status: in-development Issues and PRs with active development on them label Mar 15, 2022
@mddragnev
Copy link
Member Author

This is not a issue in the library but a sample issue, so the templating works as expected.

@mddragnev mddragnev linked a pull request Mar 15, 2022 that will close this issue
14 tasks
@mddragnev mddragnev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug grid: row-editing ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants