Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical grid test is failing with Ivy false #7091

Closed
nrobakova opened this issue Apr 9, 2020 · 1 comment · Fixed by #7100
Closed

Hierarchical grid test is failing with Ivy false #7091

nrobakova opened this issue Apr 9, 2020 · 1 comment · Fixed by #7100
Assignees
Labels
grid: hierarchical-grid keyboard-navigation version: 9.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

Hierarchical grid test is failing with Ivy false

  • igniteui-angular version: 9.1
  • browser: n/a

Steps to reproduce

Run test 'should allow navigating to start in child grid when child grid target row moves outside the parent view port.' with Ivy false

Result

the test is failing

Expected result

test should not have errors

Attachments

Attach a sample if available, and screenshots, if applicable.

@MayaKirova
Copy link
Contributor

Test fails correctly. The issue is that hierarchical row.cells returns incorrect collection of cell. Some of the returned cells no longer exist in DOM, which throws an error.

Can be reproduced in master in a hierarchical grid that has horizontal virtualization when Ivy is disabled.

  1. Disable ivy for samples:
    "angularCompilerOptions": {
    "enableIvy": false
    }
  2. Open hierarchicalGrid sample, go to "Sample three"
  3. Scroll grid to the right edge.
  4. Select cell and hit Ctrl+Home

Error is thrown:
Uncaught DOMException: Failed to execute 'selectNode' on 'Range': the given Node has no parent.
at IgxGridSelectionService._moveSelectionChrome (http://localhost:4200/main.js:51424:15)
at IgxGridSelectionService.keyboardStateOnFocus (http://localhost:4200/main.js:51281:22)
at IgxHierarchicalGridCellComponent.activate (http://localhost:4200/main.js:28025:35)
at IgxHierarchicalGridCellComponent.activate (http://localhost:4200/main.js:46796:15)
at http://localhost:4200/main.js:42201:93
at IgxHierarchicalGridComponent.executeCallback (http://localhost:4200/main.js:41192:9)
at IgxHierarchicalGridComponent.navigateTo (http://localhost:4200/main.js:41096:18)
at http://localhost:4200/main.js:41093:89
at SafeSubscriber._next (http://localhost:4200/main.js:42490:17)
at SafeSubscriber.__tryOrUnsub (http://localhost:4200/vendor.js:115307:16)

@MayaKirova MayaKirova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: hierarchical-grid keyboard-navigation version: 9.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants