-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IgxRipple - animate() function not supported in Safari #3506
Comments
@ig-robstoffers There's a slightly obscure note at the bottom of the Ripple Usage section that explains the directive uses Web Animations API and that may require a polyfil for some browsers. As you already have the package installed in your sample, all that is needed would be to uncomment this line in polyfills.ts: igniteui-angular/src/polyfills.ts Lines 53 to 57 in e7e31ae
This applies for multiple controls that rely on the @simeonoff Maybe the polyfil requirement should be more prominent on top (like the Calendar one perhaps)? Could also add a little check before calling |
Ah I see. Adding that to my polyfill.ts definitely fixed that. Thanks @damyanpetev ! |
Documentation issue has been created, closing this one. |
@rkaraivanov Can we make the change to the Web Animations builder to amend the issues? |
Description
The IgxRipple directive uses the experimental animate() function which is not currently supported by Safari, displaying an error in the console. It doesn't seem to have any ill effects but I wanted to make you aware as I didn't see an existing issue for this.
Steps to reproduce
Result
Expected result
No error is displayed and the ripple effect plays on the tab when clicked.
Attachments
tabs-animate.zip
The text was updated successfully, but these errors were encountered: