Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgxRipple - animate() function not supported in Safari #3506

Closed
ig-robstoffers opened this issue Dec 28, 2018 · 4 comments
Closed

IgxRipple - animate() function not supported in Safari #3506

ig-robstoffers opened this issue Dec 28, 2018 · 4 comments

Comments

@ig-robstoffers
Copy link
Contributor

Description

The IgxRipple directive uses the experimental animate() function which is not currently supported by Safari, displaying an error in the console. It doesn't seem to have any ill effects but I wanted to make you aware as I didn't see an existing issue for this.

  • igniteui-angular version: 6.2.4
  • browser: Safari 12.0.2 (14606.3.4)

Steps to reproduce

  1. Run attached sample in Safari browser
  2. Right click & Inspect Element to open dev tools
  3. Click on Tab 2

Result

image

Expected result

No error is displayed and the ripple effect plays on the tab when clicked.

Attachments

tabs-animate.zip

@SlavUI SlavUI added ripple 🐛 bug Any issue that describes a bug labels Jan 2, 2019
@damyanpetev
Copy link
Member

@ig-robstoffers There's a slightly obscure note at the bottom of the Ripple Usage section that explains the directive uses Web Animations API and that may require a polyfil for some browsers.

As you already have the package installed in your sample, all that is needed would be to uncomment this line in polyfills.ts:

* Web Animations `@angular/platform-browser/animations`
* Only required if AnimationBuilder is used within the application and using IE/Edge or Safari.
* Standard animation support in Angular DOES NOT require any polyfills (as of Angular 6.0).
**/
import 'web-animations-js'; // Run `npm install --save web-animations-js`.

This applies for multiple controls that rely on the AnimationBuilder but those seem to work somehow with a warning to install the poly (built-in CSS Keyframes fallback).

@simeonoff Maybe the polyfil requirement should be more prominent on top (like the Calendar one perhaps)?

Could also add a little check before calling .animate() or go through Angular's API to avoid the error if the poly is missing.

@damyanpetev damyanpetev added 📈 enhancement 📖 documentation and removed 🐛 bug Any issue that describes a bug labels Jan 2, 2019
@ig-robstoffers
Copy link
Contributor Author

Ah I see. Adding that to my polyfill.ts definitely fixed that. Thanks @damyanpetev !

@zdrawku
Copy link
Contributor

zdrawku commented Jan 4, 2019

Documentation issue has been created, closing this one.

@zdrawku zdrawku closed this as completed Jan 4, 2019
@simeonoff
Copy link
Collaborator

@rkaraivanov Can we make the change to the Web Animations builder to amend the issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants