Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igx-nav-drawer uses aside semantic element with incompatible role #14847

Closed
kdinev opened this issue Sep 30, 2024 · 0 comments · Fixed by #14976
Closed

igx-nav-drawer uses aside semantic element with incompatible role #14847

kdinev opened this issue Sep 30, 2024 · 0 comments · Fixed by #14976
Assignees
@damyanpetev @desig9stein
Labels
aria-support 🐛 bug Any issue that describes a bug 👀 status: in-review Issue is currently being reviewed nav-drawer severity: low version: 18.1.x ♿ a11y When the issue or PR is related to accessibility ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Sep 30, 2024

Description

The aside element is semantic for role="complementary" but is being applied role="navigation" in the igx-nav-drawer.

  • igniteui-angular version: 18.1.x
  • browser: all

Steps to reproduce

  1. Define a nav drawer with template and mini template
  2. Define some nav items
  3. Run lighthouse analysis on the application

Result

There's an accessibility issue reported.

Expected result

There should be no accessibility issues reported.

Attachments

image
@kdinev kdinev added 🐛 bug Any issue that describes a bug nav-drawer 🆕 status: new severity: low ♿ a11y When the issue or PR is related to accessibility aria-support version: 18.1.x labels Sep 30, 2024
@simeonoff simeonoff assigned desig9stein and unassigned simeonoff Oct 28, 2024
@desig9stein desig9stein added 👀 status: in-review Issue is currently being reviewed and removed 🆕 status: new labels Oct 28, 2024
This was referenced Oct 29, 2024
Merged
Merged
@desig9stein desig9stein added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damyanpetev damyanpetev

@desig9stein desig9stein

Labels
aria-support 🐛 bug Any issue that describes a bug 👀 status: in-review Issue is currently being reviewed nav-drawer severity: low version: 18.1.x ♿ a11y When the issue or PR is related to accessibility ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(navigation-drawer): fix ARIA role issue warning. IgniteUI/igniteui-angular
4 participants
@kdinev @damyanpetev @simeonoff @desig9stein