Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xplat] - Filter dialog shifts up when the grid's height is reduced sometimes more so than needed #14702

Open
mddifilippo89 opened this issue Aug 28, 2024 · 1 comment
Assignees
Labels

Comments

@mddifilippo89
Copy link

Description

The filter dialog will appear higher up from the mouse position clicked occurred. This is a continuation of the following bug:
#14675

eg. Ideally the mouse position (0,0) would be the three dots in the column header would be where the dialog would appear from regardless if there no height is available.

I find that in Angular it's appropriately readjusted only under extreme grid crunch with no visible way to show the entire dialog. In xplat (react, webcomponents) etc. this behavior occurs sooner than expected; meaning the grid hasn't shrunk enough to warrant the dialog from appearing at a higher position. So this bug may not be for Angular specifically but worth taking a look at to see what exactly should be dialog be doing in the first place. Personally I'd like a way to toggle off this position so this never happens.

Here is a comparison of compact mode between react and angular
image

Eventually Angular will mimic react under tighter height requirements. So the issue can appear but it's less obvious and more expected.

image

@wnvko
Copy link
Contributor

wnvko commented Oct 31, 2024

Not a bug.
Filtering dialog is shown attached to the filtering button and it size is not related to the grid. Even if the grid is extremely small if there is a place for the filtering dialog it will be shown like this in all platforms:
image
However, the positioning strategy will try to fit the filtering dialog in the screen, not in the grid. While this happens filtering dialog starting position may change and not be where the filtering button is. First thing overlay will try is to flip the filtering dialog to show to the left instead to the right if there is no place to show to the right:
image
If there is no place on both sides overlay will move the filtering dialog and will try to fit in on the screen:
image
So I do not see a bug in the positioning here. Probably the issue is how-much responsive and how-much mobile friendly is the filtering dialog. IMO making the filtering dialog responsible and mobile friendly is feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants